https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

06/23/2021, 9:35 PM
looks like i’m on release duty for Friday: it sounded like we were ready for a
2.6.0rc0
?
👍 1
h

hundreds-father-404

06/23/2021, 9:44 PM
Yeah. I was hoping to get my stub_mapping PR and @steep-breakfast-98857's poetry PR landed first tho
w

witty-crayon-22786

06/23/2021, 9:55 PM
i can wait till the weekend if it comes to it.
@hundreds-father-404: would you mind putting those in a
2.6.x
milestone in github?
well, don’t worry about it. you’re not here today.
👍 1
h

hundreds-father-404

06/23/2021, 9:57 PM
I got close to finishing module mapping last night, I should be able to finish when I'm back tomorrow @steep-breakfast-98857 when you have a chance, would be good to push your changes to Poetry, even if you haven't finished responding to Stu yet. That way we can ask Benjy for a review, for example
w

witty-crayon-22786

06/25/2021, 8:05 PM
i’ll follow up on this tomorrow probably.
h

hundreds-father-404

06/25/2021, 8:06 PM
Thanks. If you have a chance, Liam's Poetry PR is ready and could use a final review I've been working on this module mapping thing, really want to get it out and am close
it ended up being harder to do than I expected, but type stubs are implemented 🚀https://github.com/pantsbuild/pants/pull/12248
w

witty-crayon-22786

06/25/2021, 9:58 PM
Nice! Disappearing for swimming shortly, but will check it out afterwards. Thank you.
h

hundreds-father-404

06/25/2021, 11:26 PM
Hm. Turns out we need to add a
DEFAULT_STUBS_MAPPING
to handle types like
types-setuptools
and
types-PyYAML
. I told myself I'd make a hard stop by now so that I can start packing for return trip to AZ, so I'm not certain I'll land this + MyPy upgrade by the weekend
But I do really think we want these two in 2.6. Could we maybe wait a few days, or do dev release today to get out Poetry, and I do rc next week? nvm, I went ahead and fixed it. Only took a few minutes
w

witty-crayon-22786

06/26/2021, 12:11 AM
We can definitely wait as long as is necessary for the release! Don't worry about changing your schedule at all.
❤️ 1
Is this all associated with a mypy upgrade? Could we revert the upgrade temporarily?
h

hundreds-father-404

06/26/2021, 12:26 AM
Yep, so that we can upgrade to 0.91 which came out last week. We don't need to technically, but I think users will expect the latest to work MyPy is practically unusable without this dep inference PR (if we stick to our guns that dep inference should almost always work)
w

witty-crayon-22786

06/28/2021, 6:52 PM
is this waiting on anything else?
h

hundreds-father-404

06/28/2021, 7:15 PM
MyPy upgrade. I'm afk all day tho and also tomorrow. It looks like only one lint failure and one test failure that should be easy to fix if you're open to taking over the PR? If you do, rebase against main and drop all but the latest commit
w

witty-crayon-22786

06/29/2021, 12:19 AM
chasing a few different things today, so i’ll wait to see if there is time for this tomorrow afternoon.