broad-processor-92400
04/01/2024, 11:56 PMfast-nail-55400
04/02/2024, 2:01 PMwide-midnight-78598
04/03/2024, 2:17 PMpants test --report --use-coverage --coverage-py-report=html --coverage-py-filter=pants.goal.migrate_call_by_name src/python/pants/goal/migrate_call_by_name_integration_test.py
nutritious-hair-72580
04/03/2024, 10:28 PMripe-gigabyte-88964
04/04/2024, 3:54 PME ValueError: Encountered 2 rule graph errors:
E No installed rules return the type FirstFakeAdditionalTargetDataFieldSet, and it was not provided by potential callers of @rule(pants.backend.project_info.peek_test:58:first_fake_additional_target_data(FirstFakeAdditionalTargetDataFieldSet) -> AdditionalTargetData).
E If that type should be computed by a rule, ensure that that rule is installed.
E If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
E No installed rules return the type SecondFakeAdditionalTargetDataFieldSet, and it was not provided by potential callers of @rule(pants.backend.project_info.peek_test:66:second_fake_additional_target_data(SecondFakeAdditionalTargetDataFieldSet) -> AdditionalTargetData).
E If that type should be computed by a rule, ensure that that rule is installed.
E If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
This is what I'm passing to the RuleRunner
- am I missing something obvious? Does the order matter?fast-nail-55400
04/05/2024, 10:15 AMwide-midnight-78598
04/05/2024, 6:35 PMwitty-crayon-22786
04/05/2024, 7:19 PMcareful-address-89803
04/07/2024, 5:07 PMbuild_file_aliases
undocumented? and is that intentional?broad-processor-92400
04/08/2024, 6:10 AMpsutil
, not arm64. https://github.com/pantsbuild/pants/issues/20765
I haven't dug into the cause other than what's in that issue. As noted in a comment, I've marked 2.19.1 as the latest (stable) release and added a note to the broken releases.fast-nail-55400
04/08/2024, 8:20 AMEnvironmentName
used by the rule graph in a test? I tried setting up the RuleRunner with:
QueryRule(ProcessResult, [Process, EnvironmentName]),
QueryRule(FallibleProcessResult, [Process, EnvironmentName]),
and then call rule_runner.request(FallibleProcessResult, [process, env_name])
but I get this error:
E Exception: Values used as `Params` must have distinct types, but the following values had the same type (`EnvironmentName`):
E EnvironmentName(val='__local_workspace__')
E EnvironmentName(val=None)
tall-country-45957
04/08/2024, 8:58 PMgentle-flower-25372
04/08/2024, 11:03 PMcurved-television-6568
04/09/2024, 12:58 PMlocal_environment
but if using a docker_environment
I'm happy to setup the Python to use in the image before hand, as it otherwise needs to install the Python every time the image boots up (it seems, not sure, as the install failed in the image I tried with..)happy-kitchen-89482
04/09/2024, 9:56 PMsrc/python/pants/jvm/
instead of src/jvm/
?nutritious-hair-72580
04/09/2024, 10:22 PMtarget
, is this the best way to get the content as text? Had to search through Slack - it seems a little convoluted 🤷
hydrated_source = await Get(HydratedSources, HydrateSourcesRequest(target[SourcesField]))
source_contents = await Get(DigestContents, Digest,
hydrated_source.snapshot.digest)
text_content = source_contents[0].content.decode()
I'm just trying to modify a property in a json file (and write it back out).proud-dentist-22844
04/13/2024, 2:20 AMwide-midnight-78598
04/13/2024, 3:12 AMpants fix fmt lint check test --all-changed
Or maybe two:
foo = "fix fmt lint check --all-changed"
bar = "foo test --all-changed"
I was just updating some documentation and noticed that we call out to the pre-commit hook, instead of just, like, an alias that would not only check, but fix tootall-processor-15402
04/13/2024, 3:51 AMcareful-address-89803
04/14/2024, 3:02 AMJvmToolBase
it would let us simplify lockfile and export machinery.happy-kitchen-89482
04/14/2024, 5:10 PM-["foo"]
syntax) is intended to override any attempt to re-add the item at a higher precedence (e.g., if removed in an env var, you cannot add it back via a CLI flag, you have to overwrite the entire list value via CLI flag to reintroduce the removed value). These tests show that this is deliberate, as does the implementation. Can anyone remember/hypothesize why this is so?broad-processor-92400
04/15/2024, 1:12 AMproud-dentist-22844
04/15/2024, 6:21 PMpy_hermetic_scripts
PR please? I want to make sure I addressed your concerns/thoughts before I merge it.
https://github.com/pantsbuild/pants/pull/20763elegant-park-52418
04/16/2024, 3:43 PMBoolOption
class MySubsystem(Subsystem):
test = BoolOption(
default=None,
help=softwrap("test"),
advanced=False,
)
From the doc string, I expect the default value to be None
, but I'm seeing False
instead. From the help output:
--[no-]mysubsystem-test
PANTS_MYSUBSYSTEM_TEST
test
default: None
current value: False
test
Any insight would be appreciated.
Slack Conversationbroad-processor-92400
04/17/2024, 1:21 AMcurved-television-6568
04/17/2024, 6:37 AMwide-midnight-78598
04/17/2024, 1:31 PMwide-midnight-78598
04/18/2024, 3:34 PMpython
hardcoding in favour of determining it on the fly (basically, our git hook installer doesn't work by default on mac)fresh-cat-90827
04/19/2024, 8:20 AMwide-midnight-78598
04/20/2024, 4:25 AMpants.engine.intrinsics
- but are these strictly types? Or should they call into something in the native engine? I'm assuming we're not exposing a pyfunction
for each of the intrinsic functions, as they're run by the scheduler (somehow, as I haven't quite figured out how the rule_visitor plays into all this yet)