pantsbuild #development

Hey folks! Continuing a discussion from Github here: https://github.com/pantsbuild/pants/issues/20084#issuecomment-1808881612 Would there be interest in migrating the Pants repo to use Ruff for formatting + linting? This could potentially provide large performance gains since Ruff is written in Rust, and would replace a variety of different tools (Black, Flake8, Autoflake, isort). Additionally, there’s a complication as we can’t opt into using Ruff as a tool for just a single goal (like

fmt

) as discussed here: https://pantsbuild.slack.com/archives/C0D7TNJHL/p1699632752483199. So to make things convenient, we have to use Ruff for formatting AND linting, or not at all. I have a branch up here with an example of the changes: https://github.com/krishnan-chandra/pants/tree/migrate-repo-ruff Let me know if you have any thoughts or questions!

bitter-ability-32190

11/14/2023, 6:30 PM

Someone check me on this. I think I need a new feature (at least for

pytest

) where the resolve the requirements come from isn't static. Instead you'd set

install_from_resolve

true

to say "install from the resolve of the test' source. It's for cases where: • You have

test_resolve_a

in resolve A. It uses fixtures or whatever, so does

import pytest

• You also have

test_resolve_b

in resolve B. Same schtick.

import pytest

• Their ICs don't overlap So no value of

install_from_resolve

would work. Not even putting

pytest

in its own resolve (because of the imports). Instead

pytest

should come from the resolve of the source file.

ancient-vegetable-10556

11/14/2023, 6:41 PM

I'm (finally) using Pants in production again and I'm trying to see how far I can get with Pants managing our CI. I'm trying to make sense of the JS backend and see that it needs some work to be a very good tool for our use case, but it seems like some things just plain don't work. Any chance one of the people who've worked on it/deployed it can tell me what features I can expect, and how I can help work on improving things? (ping @broad-processor-92400? @worried-painter-31382)

flat-zoo-31952

11/14/2023, 8:19 PM

So with PEX supporting `--exclude` now I'm thinking of picking back up the work to support extending python dep inference to support environment-provided dependencies. My first go at this tried to create a union rule around this in the python graph building code. But it looked a bit complicated to actually implement that and I'm wondering if there might be a better way? This would be an absolute game changer for our team to be able to use this, so I'm very interested in trying. But it might be useful to get some more feedback on the best way to implement this first.

curved-television-6568

11/16/2023, 9:58 PM

looking for reviewer of https://github.com/pantsbuild/pants/pull/20191

👀 1

✅ 1

fresh-cat-90827

11/19/2023, 8:07 AM

I have attempted to convert an internal plugin with TypeScript support to a standard Pants backend, please see https://github.com/pantsbuild/pants/pull/20208. It "works" but requires some adjustments, would really appreciate some help @ancient-vegetable-10556 @worried-painter-31382

👀 1

👖 1

curved-manchester-66006

11/20/2023, 2:00 PM

I'm having trouble understanding the intended consistency of INFO. From

pants lint

on an internal repo:

Copy code

16:45:09.59 [INFO] Completed: Lint Helm charts - helm succeeded.
Partition: cron-ingest-snowflake
16:45:09.59 [INFO] Completed: Lint Helm charts - helm succeeded.
Partition: cron-ingest-yes-series
16:45:09.59 [INFO] Completed: Lint Helm charts - helm succeeded.
Partition: cron-ingest-rds
16:45:09.59 [INFO] Completed: Lint Helm charts - helm succeeded.
Partition: cron-ingest-feast
16:45:11.95 [INFO] Completed: Lint with Hadolint - hadolint succeeded.
16:45:12.00 [INFO] Completed: Lint with Flake8 - flake8 succeeded.
Partition: ['CPython==3.10.*']
16:45:12.00 [INFO] Completed: Format with isort - isort made no changes.
16:45:12.00 [INFO] Completed: Format with Black - black made no changes.
16:45:12.01 [INFO] Completed: Format with Black - black made no changes.
16:45:12.01 [INFO] Completed: Format with Black - black made no changes.
16:45:12.08 [INFO] Completed: Fix with pyupgrade - pyupgrade made no changes.

• Why does

Partition:

not have a timestamp/log level? • What is a user supposed to understand from

Completed: Format with Black - black made no changes.

3 times in a row?

broad-processor-92400

11/20/2023, 10:10 PM

I'm on MOTW this week. My release plan is: • 2.16.x: we've had 2.16.1rc4 around for a while, so seems like I can cut 2.16.1 (https://github.com/pantsbuild/pants/pull/20218 ✅ ) and close the milestone... alternatively, just close the milestone without doing a final release. We're already up to 2.18.0, and releases before 2.18 are a significant investment of time... • 2.17.x: we did 2.17.1 and 2.18.0, so... nothing; close the milestone? • 2.18.x: 2.18.1rc0 soon (https://github.com/pantsbuild/pants/pull/20216, ✅) and then maybe a 2.18.1 by the end of the week with a few mostly-JVM fixes? • 2.19.x: 2.19.0rc0 as normal • main (2.20.x): 2.20.0.dev0 as normal : https://github.com/pantsbuild/pants/pull/20215 ✅ Let me know if you have thoughts.

fresh-cat-90827

11/25/2023, 9:49 PM

I am about to start integrating some of the code from my plugin to export a project's dependency graph into a JSON adjacency list. This is likely to involve adding a new goal. I would appreciate any feedback you may have, please see https://github.com/pantsbuild/pants/discussions/20242

broad-processor-92400

11/27/2023, 7:36 PM

I wrote https://github.com/pantsbuild/pants/discussions/20193 about our platform coverage in CI, including proposing potentially using a merge queue to be able to economically run more tests. Please take a look and let me know what you think.

wide-midnight-78598

11/28/2023, 3:20 AM

Copy code

thread 'main' panicked at /Users/sj/.cargo/registry/src/index.crates.io-6f17d22bba15001f/prost-build-0.12.3/src/lib.rs:1521:10:
  Could not find `protoc` installation and this build crate cannot proceed without
      this knowledge. If `protoc` is installed and this crate had trouble finding
      it, you can set the `PROTOC` environment variable with the specific path to your
      installed `protoc` binary.You could try running `brew install protobuf` or downloading it from <https://github.com/protocolbuffers/protobuf/releases>

ancient-vegetable-10556

11/29/2023, 6:23 PM

A Django-related itch I'd like to scratch (@happy-kitchen-89482, you appear to have written most of the Django plugin, so a sanity-check would be appreciated if you have the time) https://github.com/pantsbuild/pants/issues/20246

👀 1

happy-kitchen-89482

11/30/2023, 12:40 AM

IIRC running, e.g., isort as a check-only linter now runs it as a formatter under the covers and then discards the edits in the sandbox? What happens with linters that have useful output in check-only mode but not in change-the-file mode? (isort is such an example) We now lose that output, I think?

late-advantage-75311

12/01/2023, 3:36 PM

Disappeared for a bit to secure the next $-provider. That's all done and starting in Jan, so looking forward to hacking on 👖 next week. Have threads to pick back up, including getting code_quality_tool to a nice place.

❤️ 5

🎉 5

happy-kitchen-89482

12/02/2023, 10:35 PM

Can I get a review on the 2.19.0rc0 release prep? Thanks: https://github.com/pantsbuild/pants/pull/20256

✅ 1

happy-kitchen-89482

12/02/2023, 10:53 PM

And 2.20.0.dev1: https://github.com/pantsbuild/pants/pull/20257

✅ 1

happy-kitchen-89482

12/04/2023, 2:37 AM

And 2.18.1: https://github.com/pantsbuild/pants/pull/20258

✅ 2

happy-kitchen-89482

12/04/2023, 2:38 AM

BTW every release now, I do a happy dance of gratitude for all the great automation work on the release process!

❤️ 4

➕ 1

broad-processor-92400

12/05/2023, 2:00 AM

Here's a brief analysis of download stats for different versions over the last little while: https://github.com/pantsbuild/pants/discussions/20263

❤️ 2

👍 1

fresh-cat-90827

12/05/2023, 4:44 PM

was this a deliberate choice to mark a target generator as changed when any of the files it owns is deleted?

Copy code

$ rm cheeseshop/repository/package.py
$ git add cheeseshop/ 
$ git commit -m "delete file"
[main b7f25cd] delete file
 1 file changed, 395 deletions(-)
 delete mode 100644 cheeseshop/repository/package.py

$ git log --diff-filter=D --summary | grep delete     
    delete file
 delete mode 100644 cheeseshop/repository/package.py

$ pants --changed-since=origin/main list         
cheeseshop/repository:repository

🧵

✅ 1

late-keyboard-89314

12/05/2023, 6:39 PM

I have an enhancement to the Go backend that I’d like, but want to get feedback here before I start working on it. We have a need to build

go_binary

targets for multiple platforms, and right now it’s achievable through `environment`s primarily. But given how good Go’s cross-compliation support is, it seems odd to me that there’s (as far as I can tell) no native

pants

way to do that. What I’d propose is something similar to the

docker_image

target’s

build_platform

field, so you could do something like this for a Go target:

Copy code

go_binary(
    name="bin"
    go_os=["linux"]
    go_arch=["amd64", "arm64"]
)

and end up with

bin_linux_amd64

and

bin_linux_arm64

in your

dist/

outputs. Thoughts? Is there already a clean way to do this that I’m missing?

happy-kitchen-89482

12/05/2023, 8:39 PM

Proposal: hiding a few old docs versions on readme. This pulldown has become ridiculous to navigate:

💯 2

happy-kitchen-89482

12/05/2023, 8:39 PM

Screenshot 2023-12-05 at 3.38.39 PM.png

late-advantage-75311

12/06/2023, 2:56 PM

Have a few things that will benefit from feedback: • https://github.com/pantsbuild/pants/pull/20122 env var pass through for docker environments. Got feedback from Andreas and Stu and addressed it before I disappeared, but would like to get it out and possibly pick something else up relating to environments. • https://github.com/pantsbuild/pants/pull/20255 is a DRY between

code_quality_tool

and

adhoc_tool

. Daniel caught an error, and it is fixed now, but it will benefit from review from someone else familiar with adhoc_tool. • We're ready to take on the design discussion around the ergonomics part 2 of code_quality_tool which is needed before we announce it. I've summarized some of the proposals around it in https://github.com/pantsbuild/pants/issues/17729#issuecomment-1843036540

👍 1

wide-midnight-78598

12/06/2023, 10:26 PM

Would we, by any chance, happen to have a Codespace configuration setup already?

late-advantage-75311

12/07/2023, 3:21 PM

Looking for an issue to work on. Should I pick something else from the environments issue collection?

bitter-ability-32190

12/07/2023, 6:56 PM

Those familiar with environments. Is the same container used across runs? E.g. if I put something in

/foo.txt

on one run, another run will be able to see it?