witty-crayon-22786
09/29/2021, 4:43 PMUnexpandedTargets
vs Targets
, it would be a function of the Specs
…?Addresses
list (i.e. https://github.com/pantsbuild/pants/blob/52c0a3be635511a37fda5c10a291e9fd59b2eea9/src/python/pants/engine/internals/graph.py#L95-L98), and DependenciesRequest
Specs -> Addresses
hundreds-father-404
09/29/2021, 6:25 PMAddresses -> Targets
witty-crayon-22786
10/02/2021, 4:09 PMhundreds-father-404
10/02/2021, 4:34 PMwitty-crayon-22786
10/02/2021, 5:10 PMHow come?was realizing that
./pants peek ::
isn’t going to render the complete graph. it’s the same issue as list
, but brought home the impact for meIt also makes me wonder if we really should be valuing a target generator being an alias for generated targetsit needs to be when it is actually named though, right? because it disambiguates?
hundreds-father-404
10/02/2021, 5:15 PMwitty-crayon-22786
10/02/2021, 5:16 PMhundreds-father-404
10/02/2021, 5:21 PMwitty-crayon-22786
10/02/2021, 5:22 PMresources
and files
(which will generally be used via the alias) but i think the question is more whether we ever need to actually render the aliashundreds-father-404
10/02/2021, 5:24 PMfiles
and resources
, that could be solved by having the generator still depend on the generated targets. Then the atom targets will be pulled in transitively
This is only to get rid of UnexpandedTargets
vs Targets
witty-crayon-22786
10/02/2021, 5:25 PM./pants list $alias
would not be one in one out, but it would still be net easier to grok.hundreds-father-404
10/02/2021, 5:29 PMwitty-crayon-22786
10/02/2021, 5:30 PMAddress -> WrappedTarget
wouldn’t work, since the alias might give you more than one =/ … but probably an implementation detail.There’s a ton of value to looking at the target generator imo though, like ./pants peek on a go_mod target. NB that it generates targets with a different shape than itself@hundreds-father-404: then maybe it really is about the
Specs
, and only being able to see an alias when it is directly addressed?hundreds-father-404
10/02/2021, 5:39 PMwitty-crayon-22786
10/02/2021, 5:43 PMhundreds-father-404
10/02/2021, 7:26 PM