hundreds-father-404
09/29/2021, 4:01 PM./pants peek
hydrating async fields, like evaluating the sources
field, then I think there's less value for ./pants filedeps
? They now do the same thing, minus having to extract the info from JSONBUILD
not showing up anymore, which it does in filedeps
. But imo there isn't a ton of value to that?witty-crayon-22786
09/29/2021, 4:07 PMhappy-kitchen-89482
09/29/2021, 4:26 PMwitty-crayon-22786
09/29/2021, 4:26 PMsources
example makes a clearer case for using the same field name, but toggling whether it’s expanded or nothappy-kitchen-89482
09/29/2021, 4:32 PMwitty-crayon-22786
09/29/2021, 4:32 PMhappy-kitchen-89482
09/29/2021, 4:33 PMpeek
operates on Targets
instead of UnexpandedTargets
then in the python case every target has exactly one source filewitty-crayon-22786
09/29/2021, 4:33 PMhappy-kitchen-89482
09/29/2021, 4:34 PMUnexpandedTargets
should itself be optionalTargets
replaces the generators with the generatedhundreds-father-404
09/29/2021, 4:34 PMgenerated targets are generated from sources which have already been expandedNot true for languages like Go with
go_package
though. Expanding sources is still a thing for some languageswitty-crayon-22786
09/29/2021, 4:34 PMpeek
is doing todayhappy-kitchen-89482
09/29/2021, 4:34 PMwitty-crayon-22786
09/29/2021, 4:35 PMhappy-kitchen-89482
09/29/2021, 4:35 PMhundreds-father-404
09/29/2021, 4:35 PMToday at least Targets replaces the generators with the generatedRight, and I propose in https://github.com/pantsbuild/pants/pull/12952 that we change that to the semantics Stu is proposing. Project introspection shows all addressable targets
happy-kitchen-89482
09/29/2021, 4:35 PMwitty-crayon-22786
09/29/2021, 4:35 PMhappy-kitchen-89482
09/29/2021, 4:35 PMwitty-crayon-22786
09/29/2021, 4:35 PM./pants peek $onetarget
should probably show one target…?happy-kitchen-89482
09/29/2021, 4:36 PMwitty-crayon-22786
09/29/2021, 4:36 PMhundreds-father-404
09/29/2021, 4:36 PM./pants peek ::
should show everythinghappy-kitchen-89482
09/29/2021, 4:37 PM::
implicitly globs over the generated targets:
?witty-crayon-22786
09/29/2021, 4:37 PMSingleAddress
doesn’t get expanded, but a glob does.hundreds-father-404
09/29/2021, 4:37 PM:
should be all targets in that dir, generated or notwitty-crayon-22786
09/29/2021, 4:37 PMhundreds-father-404
09/29/2021, 4:38 PMdir:tgt
should be one and exactly one target (for project introspection at least)witty-crayon-22786
09/29/2021, 4:38 PMpeek
and fields…./pants dependencies --transitive --closed :: | xargs ./pants peek
…?happy-kitchen-89482
09/29/2021, 4:41 PMwitty-crayon-22786
09/29/2021, 4:42 PMpeek
, let alone trying to add json and partial field outputs to other goals