https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

02/04/2022, 6:50 PM
@witty-crayon-22786 @fast-nail-55400 I'm writing docs + blog for Apache Thrift Python support. It's awesome, although looks like we haven't added Python->Thrift dep inference, meaning you need to explicitly add Thrift deps to
dependencies
on Python targets
Ithink that's the main think blocking stabilizing Thrift in Python. Would it make sense for me to spend a half day implementing this today so that the feature & blog/docs are much more compelling?
f

fast-nail-55400

02/04/2022, 6:50 PM
I’d vote yes. I didn’t do it because other priorities.
h

hundreds-father-404

02/04/2022, 6:51 PM
f

fast-nail-55400

02/04/2022, 6:51 PM
(also I’d have to learn how Pants does Python->codegen inference.)
is there any other pressing priority on your plate?
h

hundreds-father-404

02/04/2022, 6:52 PM
This means pushing back a little me writing these blogs: • release blog • how we use Rust + Python • maybeee a dedicated Thrift blog, not sure if we want to have it dedicated vs in release
cc @busy-vase-39202
b

busy-vase-39202

02/04/2022, 6:53 PM
Pushed back by how much?
h

hundreds-father-404

02/04/2022, 6:54 PM
I'm hoping only a half day to implement this feature, making it much more useful and the blog a lot more impressive. "It Just Works", vs "It mostly works but you do have to add some explicit things every time you use Thrift in a new file"
@fast-nail-55400 is there anything else blocking Thrift from being stable for Python? Ack that we may redesign codegen for compiled languages, that shouldn't impact stabilization here imo given that Protobuf is already stable for Python
f

fast-nail-55400

02/04/2022, 6:55 PM
I don’t believe so.
example-codegen
works for it.
🙌 1
I would still keep “experimental” in the backend name for it for 2.10.
let it get bug reports in 2.10 and we can stabilize in 2.11
h

hundreds-father-404

02/04/2022, 7:00 PM
let it get bug reports in 2.10 and we can stabilize in 2.11
Alternatively, we can cherry-pick bug fixes to 2.10. Imo, stabilizing in 2.10 represents that we are committing to it being a great experience in 2.10 even if it isn't perfect on the first release
We're not going to make any API changes without normal deprecation policy, it's stable that way
f

fast-nail-55400

02/04/2022, 7:03 PM
I’ve no strong opinion. Do what you believe is best.
👍 1
h

hundreds-father-404

02/04/2022, 7:04 PM
Very exciting to delete! Thanks Tom 🙌
1
🚀 1
@busy-vase-39202 fyi I'm gonna do a less intense docs audit like I did in Pants 2.8. We changed the syntax for
python_requirement
, which touches a lot of code. might take me a little time to rewrite third-party page + write Thrift docs (almost done) + write PyOxidizer docs. All worth it 🙂
👍 1
Thrift docs are done 🙂 https://www.pantsbuild.org/v2.10/docs/thrift-python Still have to make a code change for it tho
f

fast-nail-55400

02/05/2022, 1:56 AM
I’m around if you need a review.
and thanks for doing the docs!
❤️ 1