https://pantsbuild.org/ logo
#development
Title
# development
b

bitter-ability-32190

03/29/2022, 3:53 PM
Would it make sense to elide
RequirementsPexRequest
references to just use
PexFromTargetsRequest
(and move it's functionality into the rule that resolves the latter). It's strictly a subset (and ends up creating a
PexFromTargetsRequest
with the defaults) and I'm working on a PR which would benefit from this simplification
It looks like the difference in behavior is just for
run_against_entire_lockfile
?
w

witty-crayon-22786

03/29/2022, 8:19 PM
as in, replace
RequirementsPexRequest
with a factory function on
PexFromTargetsRequest
? yea, maybe. although doing that as a separate PR might be good, since i think weโ€™ll want to cherrypick 14944 on its own
๐Ÿ‘ 1
b

bitter-ability-32190

03/29/2022, 8:21 PM
The logic is really hard to follow without this cleanup. At least IMO ๐Ÿ˜ต
w

witty-crayon-22786

03/29/2022, 8:22 PM
it definitely is. that sounds like a good idea.
b

bitter-ability-32190

03/29/2022, 8:22 PM
Maybe it's because I just roll my 7 nuerons around in my skull until I get lucky but this PR took me a lot of time to map out. I think because there's 3 main cases, and each main cases has at least 2 subcases it gets really hairy. I hope https://github.com/pantsbuild/pants/pull/14238 will make the pex code much easier to grok
That and maybe some heavy deprecation ๐Ÿ˜‚ y
h

hundreds-father-404

03/29/2022, 8:37 PM
yeah it's super confusing to follow everything, so many abstractions
+1 to dedicated PR
w

witty-crayon-22786

03/29/2022, 8:42 PM
yep. PEX and multiple lockfiles both being stable is going to kick off a very lovely deprecation and removal period i think.
b

bitter-ability-32190

03/29/2022, 8:42 PM
+1 to dedicated PR
Would y'all raze me at the stake if it's not a separate one? ๐Ÿ‘‰ ๐Ÿ‘ˆ
w

witty-crayon-22786

03/29/2022, 8:42 PM
Would yโ€™all raze me at the stake if itโ€™s not a separate one? ๐Ÿ‘‰ ๐Ÿ‘ˆ
iโ€™m fine with that. i guess you already touch all the same files
๐Ÿ˜Œ 1