do we prefer TOML or YAML for ancillary config fil...
# developmentf
fast-nail-55400
03/29/2022, 4:13 PMdo we prefer TOML or YAML for ancillary config files?
fast-nail-55400
03/29/2022, 4:14 PMcontext: I am adding a config file separate from pants.toml for configuring BSP build targets.
fast-nail-55400
03/29/2022, 4:14 PM(The BSP config file’s p ath would be specified in pants.toml via an option.)
b
bitter-ability-32190
03/29/2022, 4:16 PMThe fact that Pants uses
pants.tomlf
fast-nail-55400
03/29/2022, 4:19 PMnot really, since the regex-lint linter uses YAML for its ancillary config file.
👀 1
fast-nail-55400
03/29/2022, 4:19 PMand my ulterior motive is that I prefer YAML, so I’m testing how strong the TOML preference is.
b
bitter-ability-32190
03/29/2022, 4:23 PMFWIW I'm told the general dev community prefers TOML over YAML. for human readaibility. YAML has a lot of nasty cases (I found this quite funny: https://github.com/cblp/yaml-sucks)
I think @hundreds-father-404 can comment on why the regex-linter uses YAML. However I think it's important to remember that went from an internal tool to an external one. So perhaps it would've been TOML if it was external from the start?
bitter-ability-32190
03/29/2022, 4:25 PMThere's these too: https://www.arp242.net/yaml-config.html#surprising-behaviour
This one is funny:
Copy code
python: 3.5.3
postgres: 9.3 Copy code
{'python': '3.5.3', 'postgres': 9.3}👀 1
f
fast-nail-55400
03/29/2022, 4:32 PMI think @hundreds-father-404 can comment on why the regex-linter uses YAML. However I think it’s important to remember that went from an internal tool to an external one. So perhaps it would’ve been TOML if it was external from the start?good point
fast-nail-55400
03/29/2022, 4:32 PMwill stick with TOML then
👍 1
w
wide-midnight-78598
03/29/2022, 6:27 PMTOML gives me the INI shakes
wide-midnight-78598
03/29/2022, 6:28 PMBut
pyproject.tomlh
hundreds-father-404
03/29/2022, 7:59 PMI personally like TOML much more than YAML because the edge cases
Re: regex-linter, no special reason. Pants has generic support for reading dictionary options from a file, which I think can be
.json.yamltomlp
polite-garden-50641
03/29/2022, 9:14 PMwe should avoid yaml... it has a bunch of security issues.
toml is preferable, and I think regex-lint should move to that too (deprecate yaml, and allow either toml or json).. so we can remove the yaml library dependency from pants.
just my 2c.
💯 1
➕ 1
h
hundreds-father-404
03/29/2022, 9:34 PMI would love to remove the YAML dep from Pants!!! 🙌
🎉 2
🚀 2
hundreds-father-404
03/29/2022, 9:44 PMAsher would you be willing to open an issue with your proposal? It'd prob be helpful to link to the mentioned security issues
I don't have much time for "fun" projects like this this month w/ the doctors visits etc, but happy to help pitch into the effort
p
polite-garden-50641
03/31/2022, 1:03 PM