https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

06/23/2022, 4:29 PM
regarding the 2.12 release:
i’ve started on the release blog
but i also fixed two more issues that i’d like to pick today: so i’m thinking one more rc today
@hundreds-father-404: how much do you think that we would be leaving un-audited if we released on Monday?
h

hundreds-father-404

06/23/2022, 4:42 PM
as in, un-audited docs? quite a bit. I haven't even started updating 2.12 docs for 2.12 changes. According to git, 2.11 and 2.12 are nearly identical
w

witty-crayon-22786

06/23/2022, 4:44 PM
can you assign me about 1/3 of the 2.12 audit? i think that i should have time.
h

hundreds-father-404

06/23/2022, 4:46 PM
Sure, how about you do JVM, Go, Shell, Docker, and Helm? That leaves me Python + Plugin API + general docs
w

witty-crayon-22786

06/23/2022, 4:46 PM
will do. thanks.
❤️ 1
h

hundreds-father-404

06/23/2022, 4:47 PM
This is the doc I use to keep track of each page. Feel free to fork 2.12 tab when you're ready
👍 1
also imo we should not start 2.12 docs updates until 2.11 is done. I have probably one more hour of catching up, then will switch to picking that up again If you're free, it would be helpful to do some of those, e.g. Docker audit
w

witty-crayon-22786

06/23/2022, 6:23 PM
ok, all of the 2.12 picks are out. will do a 2.12 rc once they land, and work on the release blog and docs audit before next week
👍 1
how did you create the list of titles? it’s missing some pages
h

hundreds-father-404

06/24/2022, 4:49 PM
manually. indeed, 2.12 does not have new pages added yet
also note I haven't finished the 2.11 audit yet, we need to do that first
w

witty-crayon-22786

06/24/2022, 4:52 PM
it seems like maybe this would be easier to do the other way around… by searching for keywords based on the commit log, and then updating the relevant pages?
h

hundreds-father-404

06/24/2022, 4:53 PM
indeed, that is another approach and one of the biggest reasons I wanted in-repo docs. Searching was not possible before
but this all is temporary imo. Moving forward, we will update docs at the same time as making code changes. So no need to retroactively audit what is stale
w

witty-crayon-22786

06/24/2022, 4:54 PM
ok. i’ll scan the commit log for the topics above then probably.
because even just updating the titles in this sheet seems like a losing battle
…maybe starting with 2.12… finish checking the boxes for 2.11.
h

hundreds-father-404

06/24/2022, 4:55 PM
I think we should use the sheet for 2.11 and at least 2.12, given that we did not update docs at same time as code -- I don't feel confident a per-commit approach will catch everything
w

witty-crayon-22786

06/24/2022, 4:55 PM
how could it not?
h

hundreds-father-404

06/24/2022, 4:56 PM
if our search isn't exhaustive enough. although I suppose that we would have that same problem with the new approach moving forward..so I guess we're depending on the quality of our searches
w

witty-crayon-22786

06/24/2022, 4:56 PM
i don’t think that we have the resources for the swiss cheese approach of re-auditing things that haven’t changed multiple times in case we missed something the first time
h

hundreds-father-404

06/24/2022, 4:56 PM
Okay, per-commit sounds good for 2.12 and 2.13. Maybe we split it up that you take 1-2 dev releases?
(after we finish 2.11, which seems like a precursor)
w

witty-crayon-22786

06/24/2022, 4:57 PM
yea.
i would be great if there were better verticals to slice it on, but yea: by dev releases makes sense.
i’ll grab some of the rows in the 2.11 sheet… let me know if you’re already on them.
h

hundreds-father-404

06/24/2022, 5:34 PM
thank you. I am not -- trying to fix code issues with the release branches first
w

witty-crayon-22786

06/24/2022, 7:04 PM
page
pages (e.g. https://www.pantsbuild.org/page/language-support) are common across all versions, right?
h

hundreds-father-404

06/24/2022, 7:08 PM
yeah
but we still audit them to see if changes were necessary, e.g. did we add a new language
w

witty-crayon-22786

06/24/2022, 7:09 PM
yea. will just be a direct-in-Readme edit
👍 1
@hundreds-father-404, @bitter-ability-32190: do you think that python resource inference should go on the generic https://www.pantsbuild.org/v2.11/docs/assets page, or only on a python page?
h

hundreds-father-404

06/24/2022, 7:15 PM
probably python page, but idk where it would go in python 🤔 and then have a toolbox in generic page that cross refernces python page, maybe?
really, we should have a dedicated dependency inference page for Python imo, which talks about things like string imports & asset inference not sure now is the time to restructure that though
1
I don't really like the
goals
vs
overview
vs
integrations
organization that (I think) I introduced way back ago
b

bitter-ability-32190

06/24/2022, 7:27 PM
I really wish I had time to improve the inference code as well 😞
h

hundreds-father-404

06/24/2022, 7:36 PM
we could also not document it for now, but we should make a GH ticket to track it
w

witty-crayon-22786

06/24/2022, 7:36 PM
yea, i put it down as a TODO in the auditing.
👍 2
ok: i’m done with 2.11 docs. will work on 2.12 and the 2.12 release blog on Monday.
❤️ 1
h

hundreds-father-404

06/27/2022, 3:52 PM
thank you! are there any PRs you have to post for 2.11? I'll switch mine to review mode
w

witty-crayon-22786

06/27/2022, 4:38 PM
there was only one: already posted, but will need picks.
h

hundreds-father-404

06/27/2022, 4:49 PM
Okay cool. How do you want to split up 2.12? You do x number of releases and I do the rest?
@witty-crayon-22786 to clarify, did you do the pages for 2.11 that weren't assigned to you already? like
Using Pants -> Setting up IDE
? They are not marked as
x
in the spreadsheet
w

witty-crayon-22786

06/27/2022, 4:59 PM
no, i only did the ones i marked
👍 1