https://pantsbuild.org/ logo
#development
Title
# development
c

curved-television-6568

06/23/2022, 4:10 PM
I just noticed a corner for
cli.alias
🧵
👀 1
If you have a
~/.pants.rc
file with a
Copy code
[cli.alias]
foo = bar
and in a projects
pants.toml
Copy code
[cli.alias]
other = alias
then, the aliases from
pants.toml
will not show up…
This is not only for cli.alias, obviously, but generically for nested config data not being merged.
h

hundreds-father-404

06/23/2022, 4:12 PM
specifically DictOption I think
c

curved-television-6568

06/23/2022, 4:12 PM
yea
h

hundreds-father-404

06/23/2022, 4:13 PM
pretty sure Benjy fixed list options so that
.add
and
.remove
respect other config files
h

happy-kitchen-89482

06/23/2022, 4:13 PM
Yeah, we don't merge dicts across config files afaicr
lists do work
c

curved-television-6568

06/23/2022, 4:13 PM
in some circumstances, this is probably the correct behaviour, though…
well, it’s a gotcha.
h

hundreds-father-404

06/23/2022, 4:14 PM
But that doesn't work with the nice TOML dicts we want to use. We'd need want to add first class support for
[cli.alias.add]
, simliar to
[cli].my_list_opt.add
1
💯 1
c

curved-television-6568

06/23/2022, 4:16 PM
Great!
h

hundreds-father-404

06/23/2022, 4:17 PM
feel free to open an issue for that TOML syntax support. I don't think it would be very hard to do
c

curved-television-6568

06/23/2022, 4:18 PM
Sure thing. Will get to it later today or tomorrow.
I started looking at it, but didn’t really grok where the
+[…],-[…]
syntax was resolved into a single list object, so my mental map wasn’t clear as to if/how/where the same would work for
+{…},-{…}
😉
h

happy-kitchen-89482

06/24/2022, 9:59 AM
I probably know this code best so I'll take a look at it
❤️ 2