https://pantsbuild.org/ logo
Join Slack
Powered by
The recently released 2.17.0rc0 wheel doesn’t have...
# development
f
The recently released 2.17.0rc0 wheel doesn’t have the new 
taplo
backend tool:
Copy code
$ unzip -l pantsbuild.pants-2.17.0rc0-cp39-cp39-macosx_11_0_arm64.whl | grep taplo
even though the subpackage is in the repo at that tag: https://github.com/pantsbuild/pants/tree/601f885c7151f67875f7c9b523121ae8d3386379/src/python/pants/backend/tools
h
Offhand I don't see any import from 
taplo
, so dep inference has nothing to hang on to?
f
Would adding it to the backends in 
pants.toml
satisfy the inference piece?
c
f
Thanks @curved-television-6568 Should I add that to 18998, or make a new PR?
c
I think a dedicated PR is easier to get picked to 2.17…
f
👍
Will submit later today
👍 1
h
How does this work for all the other tools we don't import?
Oh wait, taplo is not a python tool at all!
Sorry, everything I wrote above is based on a misunderstanding of the problem, so ignore me
But yes, @curved-television-6568 is correct about adding the dep to the backend
b
This is so error prone 😭
➕ 1
c
there ought to be a linter that can report “unreachable” code.
f
https://github.com/jendrikseipp/vulture turned up in a quick google search 🙂 Not sure how it could tie in to pants dependency management though 😄
c
yea, I think we can get away with simply looking for modules without any dependents
h
@future-oxygen-10553 when you tested your change this must have worked, presumably
b
You can use backends in the pants repo, while they aren't in the wheel published
It happened to me with 
preamble
c
Yea this is a frequent gotcha that only shows itself when used in a released version.
h
Urgh
A test would be good
👍 1
Open in Slack
PreviousNext
Powered by