https://pantsbuild.org/ logo
Join Slack
Powered by
RFC: Running `taplo` on the Pants repo to format `...
# development
b
RFC: Running 
taplo
on the Pants repo to format 
.toml
files: https://github.com/pantsbuild/pants/pull/18998
f
Is 
pants fix ::
run as part of the pre-commit/CI? I didn’t specifically add taplo to any checks anywhere
b
CI uses 
lint ::
, of which all fixers (and formatters) are run. If they would've made changes, they fail 
lint
(without actually making changes)
👍 1
p
Some of the list changes were eye opening (condensing some lists onto one line), but nothing particularly uncomfortable.
The one thing I might change is 
line_length: 80
=> 
line_length: 100
to use the same as black and isort. Even that is a weak bikeshed/suggestion, and I’m fine if we don’t implement it.
f
@bitter-ability-32190 That’s what I was hoping for!
@proud-dentist-22844 I think (although I didn’t verify) that, like black, you can force taplo to keep list entries on new lines by ending each one with a comma
Including the last one
p
Nah. Some of the changed files (like in testprojects/) had the trailing comma but were still condensed.
f
Really, well good thing I qualified with “i didn’t verify” 😜
😛 1
w
I’m on team “standards, any standards - but please standards”
I agree with the line length - keeping it consistent with what we use elsewhere. And big proponent of multi-line lists if taplo can do it, just to keep future git changes cleaner
b
Y'all uhh, wanna comment on PR?
f
I updated the taplo config in the PR, thanks for the suggestions!
3 Views
Open in Slack
PreviousNext
Powered by