Replace

externs::store_bytes(metric.as_bytes()),

with

externs::store_utf8(metric),

and you should be good to go 🙂

That did it - thank you!

./pants test tests/python/pants_test/engine/legacy:parser

now will work without any error when using Python 3 pex after everything gets merged 🙂 (beyond a bunch of deprecation warnings that get printed hah)

Sweet!

collections.Mapping

(etc) will stop working in 3.8, use

collections.abc

instead. We knew about that, but decided we’ll drop Py2 before 3.8 comes out so will fix once we drop Py2 Then a bunch of bad regex, because we aren’t using raw strings (

r'regex'

) in a couple places I’ll fix the regex. We need to somehow silence the collectiosn

Cool, that doesn’t sound too horrific 😄 Good job!

Oh and

cgi.escape

will be removed in 3.8, which we’ve known about since my first first PR to Pants but have been punting because

html.escape

has slightly different semantics