average-vr-56795
12/20/2018, 6:38 PMexterns::store_bytes(metric.as_bytes()),
with
externs::store_utf8(metric),
and you should be good to go 🙂hundreds-father-404
12/20/2018, 6:44 PM./pants test tests/python/pants_test/engine/legacy:parser
now will work without any error when using Python 3 pex after everything gets merged 🙂 (beyond a bunch of deprecation warnings that get printed hah)average-vr-56795
12/20/2018, 6:44 PMhundreds-father-404
12/20/2018, 6:46 PMcollections.Mapping
(etc) will stop working in 3.8, use collections.abc
instead. We knew about that, but decided we’ll drop Py2 before 3.8 comes out so will fix once we drop Py2
Then a bunch of bad regex, because we aren’t using raw strings (r'regex'
) in a couple places
I’ll fix the regex. We need to somehow silence the collectiosnaverage-vr-56795
12/20/2018, 6:47 PMhundreds-father-404
12/20/2018, 6:47 PMcgi.escape
will be removed in 3.8, which we’ve known about since my first first PR to Pants but have been punting because html.escape
has slightly different semantics