https://pantsbuild.org/ logo
#development
Title
# development
a

aloof-angle-91616

01/28/2019, 6:01 AM
@average-vr-56795 pushed the diff! not sure how the scope of this works out. there's a short description of why the changes should be made all at once like this but i am extremely happy to split this out if any elements of the "Solution" section seem ripe for picking into constituent PRs https://github.com/pantsbuild/pants/pull/7171
a

average-vr-56795

01/28/2019, 12:33 PM
Cool - FWIW one of the big advantages of separating things out is making it easier to review, so generally trying to do so before pushing things is handy… And if you can have your published commit history be useful standalone changes, that helps too… Things I would separate out into separate PRs: • Move encoding/decoding to Store • Switch remote.rs to use new protos Things I would separate out into separate commits: • Add new lmdb to Store • Create caching thing • Wire up flags and context.rs so that the caching thing is actually used I think ideally each of those bullet points would correspond to exactly one commit, and two of them would happen to also be other PRs…
a

aloof-angle-91616

01/30/2019, 5:25 PM
forgot to respond -- can definitely do all of that! thanks for the instructions!