https://pantsbuild.org/ logo
Join Slack
Powered by
1. we should add the ability to set per-rule level...
# development
w
1. we should add the ability to set per-rule levels independent of them being named, and then we should mark most named rules debug
đź‘Ť 1
@hundreds-breakfast-49010: i don’t think we have a ticket for this, but it feels like the immediate way to address the root cause of the thread above… even if/when names are templated, we won’t want to render a lot of these at info, because the processes have better info
do you want to look at it, or i can?
h
feel free to look
w
ok, thanks.
h
I'm kinda interested in getting the digests PR I'm working on merged before we do anything else major, becuase switching from using bytes to digests is causing alot of changes all across the codebase, which makes merging more difficult
w
so… when you say “switching”, what do you mean? just on the rust side, right?
(i agree that that one is important)
h
I mean, getting rid of the 
stdout: Bytes
field on 
FallibleProcessResultWithPlatform
and replacing it withonly a 
Digest
w
right. but only the rust side, yea?
h
yeah
w
got it. ok.
h
but I think any change that would affect workunit name templeting would also involve changes on the rust side that might interact with what I'm doing
I'm just trying to think ahead wrt merge conflicts.and get this work done and merged asap
w
adding a comment based on discussion in other threads: we need levels for processes as well.
i’ll work on that today.
so, i did this: https://github.com/pantsbuild/pants/pull/9940 … but one issue i see is that if we change effectively all python rules to debug (which is the primary way to get to the amount of logging that @hundreds-father-404 seems to be looking for), other consumers of workunits won’t see much by default at Info.
maybe those other consumers (e.g. of streaming workunits) should be consuming at debug by default though… that could potentially make sense, since when you’re explicitly viewing the workunits you want to see more than what the CLI would log.
đź‘Ť 1
h
I think that makes a lot of sense. Other consumers aren’t as constrained as a small terminal. For example, Pants web UIs can implement things like collapse buttons so that the workunit info is collapsed by default
w
yea. and thinking about this more later, i think that even in those other contexts, on the order of dozens to hundreds of items in the default view makes the most sense anyway, and you can drill deeper if need be.
đź‘Ť 1
so, i think that defaulting nearly all 
@rules
to debug makes sense. i’ll get https://github.com/pantsbuild/pants/pull/9940 out of draft.
h
So long as we follow good UX, like a clear information hierarchy, agreed. A website allows us to do that in a way consoles can’t
w
Open in Slack
PreviousNext
Powered by