<@UKPS08ZGW>: it looks like rendering of failed te...
# developmentw
witty-crayon-22786
07/06/2020, 8:34 PM@hundreds-breakfast-49010: it looks like rendering of failed test workunits broke sometime recently
witty-crayon-22786
07/06/2020, 8:36 PM…or, actually… it looks like we stopped logging completion of workunits when the UI is disabled, regardless of whether they failed or not
witty-crayon-22786
07/06/2020, 8:40 PMh
hundreds-breakfast-49010
07/06/2020, 8:44 PMprobably has to do with https://github.com/pantsbuild/pants/commit/9651d48c1707930777a0852a502142bdec195e4a
hundreds-breakfast-49010
07/06/2020, 8:44 PMyeah, if the UI is disabled, we won't be calling
heavy_hittershundreds-breakfast-49010
07/06/2020, 8:44 PMand that's where the call to log completion of workunits lives
hundreds-breakfast-49010
07/06/2020, 8:44 PMafter the above commit
w
witty-crayon-22786
07/06/2020, 8:56 PMok, thanks
witty-crayon-22786
07/06/2020, 8:57 PMyea, bit of cleanup needed here and on https://github.com/pantsbuild/pants/issues/10249
h
hundreds-breakfast-49010
07/06/2020, 8:58 PMI wonder if it might be a better idea to just revert https://github.com/pantsbuild/pants/commit/9651d48c1707930777a0852a502142bdec195e4a
hundreds-breakfast-49010
07/06/2020, 8:58 PMthe point of this was to fix asher's problem, and it didn't fix it
w
witty-crayon-22786
07/06/2020, 8:59 PMmaybe. from an architectural perspective, it’s the right direction i think.
h
hundreds-breakfast-49010
07/06/2020, 8:59 PMalthough it did legitimately reduce the amount of lock contention going on, which we might be happy we've done
hundreds-breakfast-49010
07/06/2020, 8:59 PMyeah
w
witty-crayon-22786
07/06/2020, 8:59 PM#10274 seems easily fixed… we should just have a test on that probably.
witty-crayon-22786
07/06/2020, 8:59 PMunclear about #10249.