hundreds-breakfast-49010
09/24/2020, 11:58 PM.*/
as a default ignore pattern in the --build-ignore
and --pants-ignore
might be undesirablewitty-crayon-22786
09/24/2020, 11:59 PMhundreds-father-404
09/24/2020, 11:59 PM.gitignore
. My argument is that it will already ignore things like .idea/
that you don’t want
The other argument is that it’s much easier to add to pants_ignore
than to take away.ci
folder readwitty-crayon-22786
09/25/2020, 12:00 AMpants_ignore.add = ['!.ci']
right?hundreds-breakfast-49010
09/25/2020, 12:00 AMbuild_ignore = ['!.ci']
.add
is actually either broken there right now, or I misunderstand something about how the git ignore syntax workswitty-crayon-22786
09/25/2020, 12:01 AMhundreds-breakfast-49010
09/25/2020, 12:01 AMhundreds-father-404
09/25/2020, 12:02 AM.git
explicitly, and other popular VCS directorieshundreds-breakfast-49010
09/25/2020, 12:02 AM.gitignore
filehundreds-father-404
09/25/2020, 12:03 AMis that if a pants user is using a non-git vcs, some stuff might break unexpectedlyMy argument here is that it’s easier for us to help a user fix this than it is to un-ignore something. Also, that it’s less likely of a problem than the problem Thales is having of “WTF is Pants not reading this. It exists!”
witty-crayon-22786
09/25/2020, 12:03 AMwe also needwe should definitely removebuild_ignore = ['!.ci']
.*
from the default build_ignore
if it is already in pants_ignore
hundreds-breakfast-49010
09/25/2020, 12:03 AM!/.ci
and not !/.ci/*
hundreds-father-404
09/25/2020, 12:04 AMalthough I think we might say that we only explicitly support git?I don’t think so.
--changed-since
won’t work, and you’ll have to use a bit more work for pants_ignore
. But otherwise no reason to require Gitwitty-crayon-22786
09/25/2020, 12:04 AMhundreds-breakfast-49010
09/25/2020, 12:05 AMhundreds-father-404
09/25/2020, 12:06 AMit actually might make sense to try to run pants in an environment without git, just to make sure there’s nothing unexpected going onThis is the type of stress testing we need to do for 2.0. Try to break Pants as much as we can
hundreds-breakfast-49010
09/25/2020, 12:07 AM.*/
from teh --build-ignore defaults, then all we have to do to solve thales' problem is make sure "!/.ci",
is in the --pants-ignore, which is sensible enoughhundreds-father-404
09/25/2020, 12:07 AM.*
from the default for pants_ignore
to be an explicitly enumerated list like [.git, .svn]
But yeah, at least that’s an improvementhundreds-breakfast-49010
09/25/2020, 12:09 AM