hundreds-father-404
11/10/2020, 8:02 PM▶ ./pants test src/python/pants/util/strutil_test.py src/python/pants/util:tests
...
✓ src/python/pants/util/strutil_test.py:tests succeeded.
✓ src/python/pants/util/strutil_test.py:tests succeeded.
That is, the result shows up twice for the same file address. That’s because TargetRootsToFieldSets
stores a mapping of TargetsWithOrigin
to FieldSet
, and this is the same target but two distinct origins
The fix is simple for this if we can get rid of TargetsWithOrigin
et al. We no longer use that mechanism anymore, and it has some weight to support.
What do we think about shedding the ability to use WithOrigin
? In the past, we used it for globbing semantics, to only error if a certain type of spec was used. Since then, we’ve made globbing semantics more uniform to never error and only ever run on things we are able tohundreds-father-404
11/10/2020, 8:02 PMWithOrigin
witty-crayon-22786
11/10/2020, 8:04 PMhundreds-father-404
11/10/2020, 8:05 PMtargets_with_origins
property from TargetRootsToFieldSets
. But imo, if we want to keep WithOrigins
in general, we should probably have it there too
Right now we have:
* AddressesWithOrigins
* TargetsWithOrigins
* TargetRootsToFieldSets.targets_with_rigins
hundreds-father-404
11/10/2020, 8:09 PMhundreds-father-404
11/10/2020, 8:10 PMwitty-crayon-22786
11/10/2020, 9:31 PMhundreds-father-404
11/10/2020, 9:32 PMhundreds-father-404
11/10/2020, 9:33 PMwitty-crayon-22786
11/10/2020, 9:34 PMhundreds-father-404
11/10/2020, 9:34 PMwitty-crayon-22786
11/10/2020, 9:34 PMhundreds-father-404
11/10/2020, 9:34 PM