https://pantsbuild.org/ logo
#development
Title
# development
p

polite-garden-50641

01/06/2021, 5:25 PM
I'll re-run shortly (once some other shards pass)
w

witty-crayon-22786

01/06/2021, 5:56 PM
interesting. if that isn’t a flake, it might be that rustup no longer installs cargo by default. we’re not on pinned rustup, iirc.
1
p

polite-garden-50641

01/06/2021, 6:06 PM
yes, ran it several times, it fails every time, that PR is rebased on master.
h

hundreds-father-404

01/06/2021, 6:46 PM
hm, we may want to use the new rust-toolchain TOML syntax that allows us to specify precisely which components to do
👍 1
this PR doesn’t change rust code)
You have to set up the pre-commit hooks or manually add
[ci skip-rust]
for CI to avoid running those tests
h

hundreds-father-404

01/06/2021, 6:51 PM
I originally tried doing it, but gave up because the default profile included everything we need and I didn’t want to require people to have a modern version of rustup
👍 1
w

witty-crayon-22786

01/06/2021, 7:26 PM
i’ll take a swing at this, unless you already are.
h

hundreds-father-404

01/06/2021, 7:35 PM
Thanks, I have not started. Going to cherry-pick some other things instead
w

witty-crayon-22786

01/06/2021, 7:35 PM
👍
dangit. we’re missing the stdlib.
will get another change out. sorry. i thought that that shard had completed.
h

hundreds-father-404

01/06/2021, 9:24 PM
Lol. No worries, thanks
w

witty-crayon-22786

01/06/2021, 9:30 PM
… hm, they did run in my fix commit… https://travis-ci.com/github/pantsbuild/pants/jobs/469281092 … maybe the toolchain was cached…?
will wipe some caches on this attempt.
👍 1
that one is in ^
@polite-garden-50641: i can rebase https://github.com/pantsbuild/pants/pull/11415 if it would help.
p

polite-garden-50641

01/06/2021, 10:40 PM
already did it...
👍 1
forgot to push 🤦
done.