https://pantsbuild.org/ logo
Join Slack
Powered by
<https://travis-ci.com/github/pantsbuild/pants/job...
# development
p
I'll re-run shortly (once some other shards pass)
w
interesting. if that isn’t a flake, it might be that rustup no longer installs cargo by default. we’re not on pinned rustup, iirc.
❗ 1
p
yes, ran it several times, it fails every time, that PR is rebased on master.
h
hm, we may want to use the new rust-toolchain TOML syntax that allows us to specify precisely which components to do
👍 1
this PR doesn’t change rust code)
You have to set up the pre-commit hooks or manually add 
[ci skip-rust]
for CI to avoid running those tests
w
h
I originally tried doing it, but gave up because the default profile included everything we need and I didn’t want to require people to have a modern version of rustup
👍 1
w
i’ll take a swing at this, unless you already are.
h
Thanks, I have not started. Going to cherry-pick some other things instead
w
👍
dangit. we’re missing the stdlib.
will get another change out. sorry. i thought that that shard had completed.
h
Lol. No worries, thanks
w
… hm, they did run in my fix commit… https://travis-ci.com/github/pantsbuild/pants/jobs/469281092 … maybe the toolchain was cached…?
will wipe some caches on this attempt.
👍 1
that one is in ^
@polite-garden-50641: i can rebase https://github.com/pantsbuild/pants/pull/11415 if it would help.
p
already did it...
👍 1
forgot to push 🤦
done.
Open in Slack
PreviousNext
Powered by