https://pantsbuild.org/ logo
Join Slack
Powered by
I'm trying to write some tests for `RunTracker` (w...
# development
h
I'm trying to write some tests for 
RunTracker
(which we don't currently have)
I'm not sure what the right way to set 
self.options
on it is, given that it's a 
Subsystem
do we have examples of mocking subsystem options in tests somewhere?
w
please wait until i’ve got the deprecation out
h
sure
w
it will not be a subsystem any longer
h
ah okay
w
but yea, sorry… we definitely need more change in there. it’s just that removing the global subsystem stuff is easiest if i change the API a bit.
h
no worries the changes I'm making can wait until that deprecation is out
I do want to have pants tests for RunTracker but it doesn't need to happen right this second or anything
w
and actually, it looks like removing the 
Subsystem
inheritance is triggering a bunch of actual typechecking. will see how much i should fix vs skip.
h
if you want to skip some to get your PR out the door quicker I'll try to fix it in my subsequent commits
w
that’s ok… waiting on Asher’s plugin upgrade anyway
Open in Slack
PreviousNext
Powered by