https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

01/06/2021, 9:21 PM
I'm trying to write some tests for
RunTracker
(which we don't currently have)
I'm not sure what the right way to set
self.options
on it is, given that it's a
Subsystem
do we have examples of mocking subsystem options in tests somewhere?
w

witty-crayon-22786

01/06/2021, 9:24 PM
please wait until i’ve got the deprecation out
h

hundreds-breakfast-49010

01/06/2021, 9:24 PM
sure
w

witty-crayon-22786

01/06/2021, 9:24 PM
it will not be a subsystem any longer
h

hundreds-breakfast-49010

01/06/2021, 9:24 PM
ah okay
w

witty-crayon-22786

01/06/2021, 9:54 PM
but yea, sorry… we definitely need more change in there. it’s just that removing the global subsystem stuff is easiest if i change the API a bit.
h

hundreds-breakfast-49010

01/06/2021, 9:55 PM
no worries the changes I'm making can wait until that deprecation is out
I do want to have pants tests for RunTracker but it doesn't need to happen right this second or anything
w

witty-crayon-22786

01/06/2021, 11:05 PM
and actually, it looks like removing the
Subsystem
inheritance is triggering a bunch of actual typechecking. will see how much i should fix vs skip.
h

hundreds-breakfast-49010

01/06/2021, 11:07 PM
if you want to skip some to get your PR out the door quicker I'll try to fix it in my subsequent commits
w

witty-crayon-22786

01/06/2021, 11:23 PM
that’s ok… waiting on Asher’s plugin upgrade anyway