https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

06/14/2021, 5:00 PM
@hundreds-father-404: should i take a swing at https://github.com/pantsbuild/pants/issues/12019, or would you like to look at it?
and either way, would you mind putting any more information you have about it on the ticket?
h

hundreds-father-404

06/14/2021, 5:04 PM
Not sure how we want to prioritize. Other things I could work on • setup-py interpreter constraints issue that blocks a user upgrading Pants • logging for plugins not going to correct place sometimes • Per-tool lock files
w

witty-crayon-22786

06/14/2021, 5:09 PM
would continue with whatever you have context for then, that’s fine
should have a better idea of priorities by eow
h

hundreds-father-404

06/14/2021, 5:10 PM
I'll continue with this one then. Thanks! Will follow it up with setup-py, which I promised a user
w

witty-crayon-22786

06/14/2021, 5:12 PM
but do please put more context on 12019 if you have it.
it sounded like you had a repro
h

hundreds-father-404

06/14/2021, 5:17 PM
I do, but it requires using Toolchain's remote caching service in local mode. Hence my pause to put on the open source project's ticket
w

witty-crayon-22786

06/14/2021, 5:17 PM
ah, got it. can DM me
👍 1
h

hundreds-father-404

06/14/2021, 6:26 PM
I'm still debugging, but this is interesting. Adding this does not ever result in a panic when running
./pants --stats-log --no-remote-cache-read --no-process-execution-local-cache --no-pantsd lint src/python/pants/util/strutil.py
against a remote cache server with intentional slowdown of remote cache writes
Copy code
diff --git a/src/rust/engine/workunit_store/src/lib.rs b/src/rust/engine/workunit_store/src/lib.rs
index 3d56e8947..6b61d1c87 100644
--- a/src/rust/engine/workunit_store/src/lib.rs
+++ b/src/rust/engine/workunit_store/src/lib.rs
@@ -864,6 +864,7 @@ impl Drop for RunningWorkunit {
   fn drop(&mut self) {
     if let Some(workunit) = self.workunit.take() {
+      panic!("Dropped! {:?}", workunit);
       self.store.cancel_workunit(workunit);
     }
   }
 }
w

witty-crayon-22786

06/14/2021, 6:27 PM
that would mean that it successfully completed
👍 1
or that it paniced in a background thread which only got logged to
.pants.d/pants.log
… would maybe want to add some special cased logging instead or something.
👀 1
(shouldn’t be the case, but not 100% sure.)
h

hundreds-father-404

06/14/2021, 7:36 PM
hey @witty-crayon-22786 @fast-nail-55400 I think what's going on actually makes a ton of sense and there is no "bug" as we thought. Can you please check my thinking and proposed fix in https://github.com/pantsbuild/pants/issues/12019#issuecomment-860940069?
f

fast-nail-55400

06/14/2021, 8:22 PM
added a comment with a question