https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

06/14/2021, 5:45 PM
Hm I wish that we did our metric differently for remote cache writes. Rather than
remote_cache_write_{started,finished,errors}
, I wish we did
{start,success,error}
. That is,
finished
is currently a superset of
errors
, and it would be more useful for analysis if it was disjoint How would we want to approach API stability for metrics? Note that it's a good time to make this change now because they weren't working how we wanted anyways https://github.com/pantsbuild/pants/issues/12019
cc @polite-garden-50641 @fast-nail-55400 - for the Grafana dashboard showing how pantsbuild/pants remote caching is behaving, I think we can rewrite the queries to handle both schemes. After enough time has passed, drop the old scheme from the query
w

witty-crayon-22786

06/14/2021, 6:05 PM
it’s likely easiest to include the backwards compatibility in the query, yea. it’s too early to provide any sort of stability guarantee for the metrics layout
👍 1
h

hundreds-father-404

06/14/2021, 6:30 PM
remote_cache_write_starts
vs
remote_cache_write_requests
vs
remote_cache_write_attempts
? Requests is consistent with
remote_cache_read_requests
and
remote_execution_requests