https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

08/18/2021, 4:30 PM
super bikesheddy, and i apologize in advance, but: we made a decision a while back to use
white
for
INFO
,
red
for
ERROR
, and …
red
for
WARN
. i’ve just fixed application of color to logs under
pantsd
, and the red for warn continues to weird me out a bit.
👍 1
thoughts on basically just aligning to pytest’s color scheme? seems like a “dark yellow” basically
👍 1
h

hundreds-father-404

08/18/2021, 4:33 PM
Yeah I like that. So white for info, dark yellow for warn, and red for error?
w

witty-crayon-22786

08/18/2021, 4:33 PM
yea.
👍 1
f

fancy-motherboard-24956

08/18/2021, 4:38 PM
I would like to argue for light orange rather than dark yellow... (joking 😉) It sounds good to visually differentiate between errors and warnings 😄
😂 1
🔶 1
e

enough-analyst-54434

08/18/2021, 5:07 PM
For full disclosure - why was red being used for two different things deemed the right way to do things in the past?
w

witty-crayon-22786

08/18/2021, 5:08 PM
see link in OP
h

hundreds-father-404

08/18/2021, 5:09 PM
(I don't know why I had those opinions strongly one year ago and I disagree with my past self)
e

enough-analyst-54434

08/18/2021, 5:09 PM
Ok... Things like this where we come to agreement yesterday yellow is bad for reasons and tomorrow come to some other conclusion are always consternating.
That said - I like having a different color for warn.
1
h

hundreds-father-404

08/18/2021, 5:10 PM
I agree with Greg that the light yellow is bad. Idk why I didn't agree with Stu's point on dark yellow being different enough
w

witty-crayon-22786

08/18/2021, 5:10 PM
i’ll include screenshots
💯 1
…although i suspect that it is terminal specific
if anyone has any objections, please let me know above: cc @hundreds-breakfast-49010 in particular
will wait a bit.
h

hundreds-breakfast-49010

08/20/2021, 2:46 AM
I think my objection to yellow at the time was that it's hard to read on a white terminal background
a sufficiently-dark yellow or amber color doesn't have that problem
I think as long as it looks good in a light or dark terminal (and I think it does from those screenshots) there's no issue
and agree that having a color distinction between error and warning is a good idea, good change @witty-crayon-22786
👍 1