What's the history for how we ended up with both a...
# development
a
What's the history for how we ended up with both a
cache_key_gen_version
and a
cache_key_salt
on
Process
? These seem like they could be combined? (And ideally would use the
salt
field in the proto https://github.com/bazelbuild/remote-apis/blob/3e816456ee28f01ab2e0abf72306c1f340c7b229/build/bazel/remote/execution/v2/remote_execution.proto#L[…]9 rather than env vars, though I know
salt
was added after we added these fields 🙂)
w
go right ahead with merging them if you’d like… we haven’t encountered any instances of actually using
cache_key_gen_version
with
v2
, so it would be a painless deprecation
👍 2
and yea, the per-process salt value didn’t exist yet.