https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

10/28/2021, 8:38 PM
@fast-nail-55400: i’ll pick https://github.com/pantsbuild/pants/pull/13399, unless someone else already has it in flight.
actually. hm. the 2.7.x pick isn’t trivial.
👍 1
@ancient-vegetable-10556: are you able to do this?
a

ancient-vegetable-10556

10/28/2021, 8:52 PM
👀
I don’t understand what the exact issue is — we already have a
version
key in version 2.7.x
I don’t actually think there’s anything to cherry-pick here
w

witty-crayon-22786

10/28/2021, 9:00 PM
Ok, the conversation on the ticket came to a different conclusion: if it doesn't need to be picked to the final 2.7.0/2.7.1 releases, then okay cool and let's just pick at
2.8.x
.
a

ancient-vegetable-10556

10/28/2021, 9:01 PM
I didn’t go looking too deeply at the code elsewhere
I can pick to 2.8 momentarily though
h

hundreds-father-404

10/28/2021, 9:02 PM
I think the issue is if you were using 2.7.0rc2 and then upgrade to 2.7.0rc3+ without first regenerating your lockfiles. We'll fail at consumption time Maybe that's fine because there's a workaround, but it did trip up a user this morning
a

ancient-vegetable-10556

10/28/2021, 9:02 PM
2.7.0rc3+ never read the version key
it’s going from 2.7.0rc2 to 2.8.x that’s the problem
h

hundreds-father-404

10/28/2021, 9:02 PM
oh, cool 🙂
a

ancient-vegetable-10556

10/28/2021, 9:04 PM
the key we read in 2.7.x ius
requirements_invalidation_digest
— we started writing the version key to avoid compatability issues. I guess we just never anticipated people going from an early rc, and skipping the stable versions entirely
👍 1
w

witty-crayon-22786

10/28/2021, 9:42 PM
ok, thanks: so nothing else bound for 2.7.x currently?
👍 1
a

ancient-vegetable-10556

10/28/2021, 9:43 PM
Not for this issue. maybe we could consider adding a warning that lockfiles without a
version
header need to be regenerated before switching to 2.8?
h

hundreds-father-404

10/28/2021, 9:44 PM
Thanks to the cherry-pick, they don't need to be anymore. I think it's fine
w

witty-crayon-22786

10/28/2021, 9:44 PM
the missing key should be fixed in 2.8, so they’ll get a good error message there now, right?
yea
a

ancient-vegetable-10556

10/28/2021, 9:45 PM
Right, once we properly deprecate support for v1 lockfiles, they’ll get warned
so yes, there’s nothing left there
w

witty-crayon-22786

10/28/2021, 9:57 PM
i’m catching a plane at 7, so i can prepare both
2.7.2rc0
and
2.8.0rc1
, but someone else should probably run them.
👍 1
ok, i probably won’t have time to finish 2.8.0rc1 prep either: so i’ll leave it up to someone else to finish that… probably @hundreds-father-404?
👍 1
2.7.2rc0
is picked and pushed to https://github.com/pantsbuild/pants/commits/2.7.x
👍 1