i ll pick

Question

< fast nail 55400> i ll pick unless someone else already has it in flight

witty-crayon-22786 · Answer

actually hm the 2 7 x pick isn t trivial

witty-crayon-22786 · Answer

< ancient vegetable 10556> are you able to do this

ancient-vegetable-10556 · Answer

eyes

ancient-vegetable-10556 · Answer

I don t understand what the exact issue is we already have a `version` key in version 2 7 x

ancient-vegetable-10556 · Answer

I don t actually think there s anything to cherry pick here

witty-crayon-22786 · Answer

Ok the conversation on the ticket came to a different conclusion if it doesn t need to be picked to the final 2 7 0 2 7 1 releases then okay cool and let s just pick at `2 8 x`

ancient-vegetable-10556 · Answer

I didn t go looking too deeply at the code elsewhere

ancient-vegetable-10556 · Answer

I can pick to 2 8 momentarily though

hundreds-father-404 · Answer

I think the issue is if you were using 2 7 0rc2 and then upgrade to 2 7 0rc3+ without first regenerating your lockfiles We ll fail at consumption time Maybe that s fine because there s a workaround but it did trip up a user this morning

ancient-vegetable-10556 · Answer

2 7 0rc3+ never read the version key

ancient-vegetable-10556 · Answer

it s going from 2 7 0rc2 to 2 8 x that s the problem

hundreds-father-404 · Answer

oh cool slightly smiling face

ancient-vegetable-10556 · Answer

the key we read in 2 7 x ius `requirements invalidation digest` we started writing the version key to avoid compatability issues I guess we just never anticipated people going from an early rc and skipping the stable versions entirely

ancient-vegetable-10556 · Answer

<https github com pantsbuild pants pull 13406> ^ sign off please slightly smiling face

witty-crayon-22786 · Answer

ok thanks so nothing else bound for 2 7 x currently

ancient-vegetable-10556 · Answer

Not for this issue maybe we could consider adding a warning that lockfiles without a `version` header need to be regenerated before switching to 2 8

hundreds-father-404 · Answer

Thanks to the cherry pick they don t need to be anymore I think it s fine

witty-crayon-22786 · Answer

the missing key should be fixed in 2 8 so they ll get a good error message there now right

witty-crayon-22786 · Answer

yea

ancient-vegetable-10556 · Answer

Right once we properly deprecate support for v1 lockfiles they ll get warned

ancient-vegetable-10556 · Answer

so yes there s nothing left there

witty-crayon-22786 · Answer

i m catching a plane at 7 so i can prepare both `2 7 2rc0` and `2 8 0rc1` but someone else should probably run them

witty-crayon-22786 · Answer

prep for 2 8 0rc1 here <https github com pantsbuild pants pull 13408>

witty-crayon-22786 · Answer

ok i probably won t have time to finish 2 8 0rc1 prep either so i ll leave it up to someone else to finish that probably < hundreds father 404>

witty-crayon-22786 · Answer

`2 7 2rc0` is picked and pushed to <https github com pantsbuild pants commits 2 7 x>