<@U0N6C2Q9F>: i’ll pick <https://github.com/pantsb...
# developmentw
witty-crayon-22786
10/28/2021, 8:38 PM@fast-nail-55400: i’ll pick https://github.com/pantsbuild/pants/pull/13399, unless someone else already has it in flight.
witty-crayon-22786
10/28/2021, 8:40 PMactually. hm. the 2.7.x pick isn’t trivial.
👍 1
witty-crayon-22786
10/28/2021, 8:40 PM@ancient-vegetable-10556: are you able to do this?
a
ancient-vegetable-10556
10/28/2021, 8:52 PM👀
ancient-vegetable-10556
10/28/2021, 8:57 PMI don’t understand what the exact issue is — we already have a
versionancient-vegetable-10556
10/28/2021, 8:58 PMI don’t actually think there’s anything to cherry-pick here
w
witty-crayon-22786
10/28/2021, 9:00 PMOk, the conversation on the ticket came to a different conclusion: if it doesn't need to be picked to the final 2.7.0/2.7.1 releases, then okay cool and let's just pick at
2.8.xa
ancient-vegetable-10556
10/28/2021, 9:01 PMI didn’t go looking too deeply at the code elsewhere
ancient-vegetable-10556
10/28/2021, 9:01 PMI can pick to 2.8 momentarily though
h
hundreds-father-404
10/28/2021, 9:02 PMI think the issue is if you were using 2.7.0rc2 and then upgrade to 2.7.0rc3+ without first regenerating your lockfiles. We'll fail at consumption time
Maybe that's fine because there's a workaround, but it did trip up a user this morning
a
ancient-vegetable-10556
10/28/2021, 9:02 PM2.7.0rc3+ never read the version key
ancient-vegetable-10556
10/28/2021, 9:02 PMit’s going from 2.7.0rc2 to 2.8.x that’s the problem
h
hundreds-father-404
10/28/2021, 9:02 PMoh, cool 🙂
a
ancient-vegetable-10556
10/28/2021, 9:04 PMthe key we read in 2.7.x ius
requirements_invalidation_digest👍 1
ancient-vegetable-10556
10/28/2021, 9:08 PMhttps://github.com/pantsbuild/pants/pull/13406 ^--- sign-off please 🙂
w
witty-crayon-22786
10/28/2021, 9:42 PMok, thanks: so nothing else bound for 2.7.x currently?
👍 1
a
ancient-vegetable-10556
10/28/2021, 9:43 PMNot for this issue. maybe we could consider adding a warning that lockfiles without a
versionh
hundreds-father-404
10/28/2021, 9:44 PMThanks to the cherry-pick, they don't need to be anymore. I think it's fine
w
witty-crayon-22786
10/28/2021, 9:44 PMthe missing key should be fixed in 2.8, so they’ll get a good error message there now, right?
witty-crayon-22786
10/28/2021, 9:44 PMyea
a
ancient-vegetable-10556
10/28/2021, 9:45 PMRight, once we properly deprecate support for v1 lockfiles, they’ll get warned
ancient-vegetable-10556
10/28/2021, 9:45 PMso yes, there’s nothing left there
w
witty-crayon-22786
10/28/2021, 9:57 PMi’m catching a plane at 7, so i can prepare both
2.7.2rc02.8.0rc1👍 1
witty-crayon-22786
10/28/2021, 10:09 PMprep for 2.8.0rc1 here: https://github.com/pantsbuild/pants/pull/13408
witty-crayon-22786
10/28/2021, 10:51 PMok, i probably won’t have time to finish 2.8.0rc1 prep either: so i’ll leave it up to someone else to finish that… probably @hundreds-father-404?
👍 1
witty-crayon-22786
10/28/2021, 10:55 PM2.7.2rc0👍 1