https://pantsbuild.org/ logo
#development
Title
# development
p

polite-garden-50641

11/08/2021, 5:06 PM
we should probably get rid of
pystache
since it seems to be abandoned
h

happy-kitchen-89482

11/08/2021, 5:17 PM
That error is weird, but yeah, we should just get rid of pystache. We only use it in one place, which isn't even in Pants itself but in the documentation generator.
h

hundreds-father-404

11/08/2021, 5:18 PM
Ughhhh I think this blocks the 2.8 release we need today for the Go blog. We can't do blogs
p

polite-garden-50641

11/08/2021, 5:33 PM
I have a branch to replace it with something that seems to be maintained. https://github.com/asherf/pants/tree/chevron but I didn't get a chance to test it yet.
I am probably using the chevron api wrong... I have never used it before so I need to figure out how to map the usage from pystache to chevron.
hmm.. actually ran it locally and it seems to work (well, it generated a bunch of markdown files and it didn't blow up). So I will PR this change to make it easier to look at and review/test.
looking at the markdown generated is seems fine but it probably makes sense for someone else to take another look at it.
since I never ran that before.
so don't trust me.
h

hundreds-father-404

11/08/2021, 5:41 PM
Sweet! Would you like me to push directly to this PR to finish it out, like removing
pystache
and fixing up the BUILD files?
p

polite-garden-50641

11/08/2021, 5:41 PM
sure.
I will be afk for the next ~2 hours so feel free to do whatever to push this thru.
❤️ 1
h

hundreds-father-404

11/08/2021, 5:42 PM
Thank you!