we should probably get rid of `pystache` since it ...
# developmentp
polite-garden-50641
11/08/2021, 5:06 PMwe should probably get rid of
pystacheh
happy-kitchen-89482
11/08/2021, 5:17 PMThat error is weird, but yeah, we should just get rid of pystache. We only use it in one place, which isn't even in Pants itself but in the documentation generator.
h
hundreds-father-404
11/08/2021, 5:18 PMUghhhh I think this blocks the 2.8 release we need today for the Go blog. We can't do blogs
p
polite-garden-50641
11/08/2021, 5:33 PMI have a branch to replace it with something that seems to be maintained.
https://github.com/asherf/pants/tree/chevron but I didn't get a chance to test it yet.
polite-garden-50641
11/08/2021, 5:34 PMI am probably using the chevron api wrong... I have never used it before so I need to figure out how to map the usage from pystache to chevron.
polite-garden-50641
11/08/2021, 5:36 PMhmm.. actually ran it locally and it seems to work (well, it generated a bunch of markdown files and it didn't blow up).
So I will PR this change to make it easier to look at and review/test.
polite-garden-50641
11/08/2021, 5:38 PMpolite-garden-50641
11/08/2021, 5:39 PMlooking at the markdown generated is seems fine but it probably makes sense for someone else to take another look at it.
polite-garden-50641
11/08/2021, 5:40 PMsince I never ran that before.
polite-garden-50641
11/08/2021, 5:40 PMso don't trust me.
h
hundreds-father-404
11/08/2021, 5:41 PMSweet! Would you like me to push directly to this PR to finish it out, like removing
pystachep
polite-garden-50641
11/08/2021, 5:41 PMsure.
polite-garden-50641
11/08/2021, 5:41 PMI will be afk for the next ~2 hours so feel free to do whatever to push this thru.
❤️ 1
h
hundreds-father-404
11/08/2021, 5:42 PMThank you!