https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

12/13/2021, 10:09 PM
It looks like
scala_junit_test
is using
compatible_resolves
instead of
resolve
. Is that intentional?
w

witty-crayon-22786

12/13/2021, 10:45 PM
… no. should be a root. thanks!
👍 1
h

hundreds-father-404

12/13/2021, 10:47 PM
Thanks! Mentioned in https://github.com/pantsbuild/pants/pull/13869, but other thing I noticed is roots aren't overriding like envisioned in your design doc
If not supplied, the default resolve will be used. Otherwise, one resolve that is compatible with all dependency targets will be used.
Will fix these both as prework to https://github.com/pantsbuild/pants/issues/13621. (Helps me to understand these code paths better also)
w

witty-crayon-22786

12/13/2021, 10:47 PM
actually… i have more changes coming here. probably better if i do
thanks for pointing that out.
👍 1
h

hundreds-father-404

12/13/2021, 10:49 PM
Hm how soon are these coming? We'll be crossing paths a bit then Would it make sense for me to work on Python for rest of the day - there's some stuff I can definitely do related to #13261
w

witty-crayon-22786

12/13/2021, 10:50 PM
@hundreds-father-404: my changes primarily touch the scala backend’s target types
👍 1
so shouldn’t collide
h

hundreds-father-404

12/13/2021, 10:52 PM
if i do
What does "do" mean here specifically? I'm talking about two prework PRs: 1) fix all test targets to use
resolve
instead of
compatible_resolves
, 2) have
resolve
force the resolve rather than just mix it in. get rid of the
--use-resolve
option
w

witty-crayon-22786

12/13/2021, 10:52 PM
i was just going to fix the one target that you pointed out.
but yea, if that’s the case, go ahead and do all of them in one fell swoop. it’ll be easy to resolve collisions.
👍 1
h

hundreds-father-404

12/14/2021, 5:23 PM
fyi @witty-crayon-22786 I discovered two bugs with Go in Pants 2.9 while wiring up example-golang. I'm planning to work on them first today
w

witty-crayon-22786

12/14/2021, 5:54 PM
@hundreds-father-404: if they’re cherrypickable, it would be good to wait until the visibility change is in
or at least usable
h

hundreds-father-404

12/14/2021, 5:57 PM
Doing the embed bug fix because it blocks
./pants test
working entirely, but punting on fixing
go vet
. We don't need to land
go vet
in 2.9
w

witty-crayon-22786

12/14/2021, 5:57 PM
sounds good
@hundreds-father-404: is there anything i can do to help on the visibility stuff in the mean time? i’m deciding what to pick up next.
h

hundreds-father-404

12/14/2021, 6:01 PM
I have a WIP to fix
resolve
vs
compatible_resolves
handling, and probably doesn't make sense to hand off that But the followup task I had was to add
compatible_resolves
to
jvm_artifact
target. That might be able to be split out beforehand? I've been wondering for example if we want a different
help
message for that field than the
compatible_resolves
that we use with
java_source
et al? A different
--default-compatible-resolves
option too perhaps? Even if none of it gets wired up, implementing the
help
message and thinking that through could help
or @fast-nail-55400, how is your schedule? Could I hand off this embed fix to you? I now have failing integration tests, and I've identified where the code breaks. Only needs the fix now
f

fast-nail-55400

12/14/2021, 6:02 PM
sure, is there an issue?
h

hundreds-father-404

12/14/2021, 6:02 PM
let me push my wip
https://github.com/pantsbuild/pants/pull/13875/files fails for
test_embed_in_source_code
This breaks at https://github.com/pantsbuild/pants/blob/5e3317be8335bc349bc3b4444b885c70390cf8e8/src/python/pants/backend/go/util_rules/build_pkg_target.py#L86-L93. I think we need to be merging
test_embed_config
and
embed_config
, not overwriting
f

fast-nail-55400

12/14/2021, 6:11 PM
yes because internal tests are in the same package as the regular source files and are built together
1
only external tests would have separate embed config
👍 1
maybe land that PR with
@pytest.mark.xfail
? Then I’ll fix later today
👍 1