<@U06A03HV1> does *Tom and your new immutable cach...
# developmenth
hundreds-father-404
12/14/2021, 12:29 AM@witty-crayon-22786 does *Tom and your new immutable caches feature mean it should be performant for Pants to install Go for you? If so, I wonder if we should always install it for you to make things more hermetic?
hundreds-father-404
12/14/2021, 12:29 AMcc @fast-nail-55400
w
witty-crayon-22786
12/14/2021, 1:03 AMyes, it should
witty-crayon-22786
12/14/2021, 1:03 AMalso, it’s totally Tom’s feature, heh
❤️ 1
witty-crayon-22786
12/14/2021, 1:03 AMi just implemented it.
f
fast-nail-55400
12/14/2021, 1:15 AMcool!
h
hundreds-father-404
12/14/2021, 1:35 AMYay! Thoughts if we should always install it for you? Relates to the terraform discussion imo
hundreds-father-404
12/14/2021, 1:36 AMIf so, I think we may want to spend a half day switching this out as a breaking change in Pants 2.9. I'd rather make the break now than in 2.10
f
fast-nail-55400
12/14/2021, 2:17 AMit would be beneficial to support both searching for a pre-installed GOROOT and downloading a distribution. remote execution would still need to merge the downloaded go dist into the input root, which could have performance issues. let’s wait to implement this in 2.10 and then properly support specifying either method.
👍 1
fast-nail-55400
12/14/2021, 2:17 AMthis intersects somewhat with multi-platform and being able to specify a toolchain that matches the execution and host platforms
➕ 1
fast-nail-55400
12/14/2021, 2:18 AMcontinuing to search local paths for the GOROOT is fine for 2.9
w
witty-crayon-22786
12/14/2021, 6:14 PMooooo, sidenote. i think i just realized that a large portion of the time for
goxprotectwitty-crayon-22786
12/14/2021, 6:15 PMxprotectcoursier❗ 1
witty-crayon-22786
12/14/2021, 6:16 PMbecause it apparently tracks binaries based on their location in the filesystem rather than their digest
witty-crayon-22786
12/14/2021, 6:16 PManywho.