does Tom and your new immutable caches

Question

< witty crayon 22786> does Tom and your new immutable caches feature mean it should be performant for Pants to install Go for you If so I wonder if we should always install it for you to make things more hermetic

hundreds-father-404 · Answer

cc < fast nail 55400>

witty-crayon-22786 · Answer

yes it should

witty-crayon-22786 · Answer

also it s totally Tom s feature heh

witty-crayon-22786 · Answer

i just implemented it

fast-nail-55400 · Answer

cool

hundreds-father-404 · Answer

Yay Thoughts if we should always install it for you Relates to the terraform discussion imo

hundreds-father-404 · Answer

If so I think we may want to spend a half day switching this out as a breaking change in Pants 2 9 I d rather make the break now than in 2 10

fast-nail-55400 · Answer

it would be beneficial to support both searching for a pre installed GOROOT and downloading a distribution remote execution would still need to merge the downloaded go dist into the input root which could have performance issues let s wait to implement this in 2 10 and then properly support specifying either method

fast-nail-55400 · Answer

this intersects somewhat with multi platform and being able to specify a toolchain that matches the execution and host platforms

fast-nail-55400 · Answer

continuing to search local paths for the GOROOT is fine for 2 9

witty-crayon-22786 · Answer

ooooo sidenote i think i just realized that a large portion of the time for `go` on macOS was probably not in sandbox creation but rather on `xprotect` symlinking is still the solution though

witty-crayon-22786 · Answer

`xprotect` re scanning each new `coursier` binary added about 4 5 seconds per invoke with contention

witty-crayon-22786 · Answer

because it apparently tracks binaries based on their location in the filesystem rather than their digest

witty-crayon-22786 · Answer

anywho