https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

12/14/2021, 12:29 AM
@witty-crayon-22786 does *Tom and your new immutable caches feature mean it should be performant for Pants to install Go for you? If so, I wonder if we should always install it for you to make things more hermetic?
cc @fast-nail-55400
w

witty-crayon-22786

12/14/2021, 1:03 AM
yes, it should
also, it’s totally Tom’s feature, heh
❤️ 1
i just implemented it.
f

fast-nail-55400

12/14/2021, 1:15 AM
cool!
h

hundreds-father-404

12/14/2021, 1:35 AM
Yay! Thoughts if we should always install it for you? Relates to the terraform discussion imo
If so, I think we may want to spend a half day switching this out as a breaking change in Pants 2.9. I'd rather make the break now than in 2.10
f

fast-nail-55400

12/14/2021, 2:17 AM
it would be beneficial to support both searching for a pre-installed GOROOT and downloading a distribution. remote execution would still need to merge the downloaded go dist into the input root, which could have performance issues. let’s wait to implement this in 2.10 and then properly support specifying either method.
👍 1
this intersects somewhat with multi-platform and being able to specify a toolchain that matches the execution and host platforms
1
continuing to search local paths for the GOROOT is fine for 2.9
w

witty-crayon-22786

12/14/2021, 6:14 PM
ooooo, sidenote. i think i just realized that a large portion of the time for
go
on macOS was probably not in sandbox creation, but rather on
xprotect
. symlinking is still the solution though
xprotect
re-scanning each new
coursier
binary added about 4-5 seconds per invoke with contention
1
because it apparently tracks binaries based on their location in the filesystem rather than their digest
anywho.