Should `--stats-log` supersede `level`? I have `le...
# developmentb
bitter-ability-32190
12/21/2021, 3:46 PMShould
--stats-loglevellevelwarnh
hundreds-father-404
12/21/2021, 3:48 PMProbably not supersede. Imo you often get spaghetti code when introducing coupling like that
But perhaps a warning in this situation? Iirc the code is stats_aggregator.py. I think you can request the LogLevel type as a parameter to the @rule
🤔 1
b
bitter-ability-32190
12/21/2021, 3:50 PMI guess a second way of slicing it. Why does it
logbitter-ability-32190
12/21/2021, 3:51 PM"I want to see only warnings AND I want to see the stats" is a totally reasonable thing to request 😉
h
hundreds-father-404
12/21/2021, 3:58 PMOhhh hm I was confusing this with something more subtle, but I think this isn't true. I was thinking that we don't capture the stats info for "workunits" that aren't WARN or ERROR, but I think that's not true
So, for stats-log, we have to log. There's no way to print to the console because it's not a goal-rule and we can't get exclusive access to Console. The best we could do is log at a higher level like WARN
But probably a better solution is to use --log-levels-by-target, which lets you override to use INFO for just one part and WARN everywhere else
hundreds-father-404
12/21/2021, 4:00 PMSo, the warning would suggest using --log-levels-by-target to fix this, rather than --level
b
bitter-ability-32190
12/21/2021, 4:03 PMThe technical limitation makes sense, but I'll maintain logging feels goofy here 😉
bitter-ability-32190
12/21/2021, 4:04 PMWhat's the right key to use for
log-levels-by-targetbitter-ability-32190
12/21/2021, 4:44 PMHmmmmm:
Copy code
level = "warn"
log_levels_by_target = {"pants.goal.stats_aggregator" = "info"} Copy code
0:42:38.47 [INFO] (pants.goal.stats_aggregator) Counters:
local_cache_read_errors: 0
local_cache_requests: 23
...bitter-ability-32190
12/21/2021, 4:49 PM.
bitter-ability-32190
12/21/2021, 5:02 PMEither I'm doing something wrong or
log_levels_by_targetbitter-ability-32190
12/21/2021, 5:23 PMYeah, I tried swapping the levels to see if
log_levels_by_target Copy code
level = "debug"
log_levels_by_target = {'pants.goal.stats_aggregator' = "warn"} Copy code
11:21:40.91 [INFO] (pants.goal.stats_aggregator)bitter-ability-32190
12/21/2021, 5:32 PMI'm going to file an issue, I think I know why
bitter-ability-32190
12/21/2021, 5:35 PMbitter-ability-32190
12/21/2021, 5:43 PMWell that was easy: https://github.com/pantsbuild/pants/pull/13939
🙌 1
🚀 1