I m wanting to reduce some boilerplate for linters formatter

Question

I m wanting to reduce some boilerplate for linters formatters both in terms of in function repeating the tool name and between the functions My motivation is mostly because I want to add a field to `LintResults` and think it s a shame that each linter will have to supply the field even though they all supply it with the same expression There s also the make linters formatters easier camp too So I m wondering if it d be worthwhile to improve the rule parser to follow call trees still doing things dumb ly where it makes sense nothing crazy to allow for some re use for this and many other cases I don t think it d be too difficult thinking face Thoughts < witty crayon 22786>

curved-television-6568 · Answer

I for one would love that and have also pondered on the feasibility to implement something of the sorts

bitter-ability-32190 · Answer

I think it s relatively easy given some sane constraints and error messaging and remembering the point is to improve current art so it doesn t have to go the extra mile

bitter-ability-32190 · Answer

I think I can whip up a PoC

bitter-ability-32190 · Answer

PoC done and looking good thumbsup

bitter-ability-32190 · Answer

Teaser ``` rule desc= Format with Black level=LogLevel DEBUG async def black fmt field sets BlackRequest black Black gt FmtResult return run black field sets black is lint=False ``` ```joshuacannon CEPHANDRIUS ~ work pants$ pants help LintResults | grep black 10 08 38 82 INFO Initializing scheduler 10 08 39 20 INFO Scheduler initialized pants backend python lint black rules black lint activated by pants backend python lint black```

curved-television-6568 · Answer

ooohhh sweet heart

curved-television-6568 · Answer

is ` run black` a regular function then

bitter-ability-32190 · Answer

Next Try and define a `fmt` or `lint` template out of tool

bitter-ability-32190 · Answer

Note I know this muddies the rule graph right now it s just for exposition ```async def run black field sets BlackRequest black Black is lint bool gt FmtResult | LintResults ```

curved-television-6568 · Answer

Cool right it would have to be an async hear no evil stuck out tongue

hundreds-father-404 · Answer

I think one big semantic change is that the ` run black` rule doesn t get memoized with the engine It would be equivalent fwict to copying and pasting inlining all that code into both the `fmt black` and `lint black` rules I m pretty sure that s okay only something to be aware of I like that this allows you to DRY without having to create wrapper types because it s just an async function not a proper rule

hundreds-father-404 · Answer

Do you have a WIP you can post for the parsing change I m curious how it works including whether we follow imports

bitter-ability-32190 · Answer

gt I like that this allows you to DRY without having to create wrapper types because it s just an async function not a proper rule Yeah that s the idea Add the ability to make helpers so all your code doesn t have to choose between inline everything or rule overhead

bitter-ability-32190 · Answer

gt Do you have a WIP you can post for the parsing change I m curious how it works including whether we follow imports I will once I do a smidge more smoke testing And yes it follows imports albeit dumbly

hundreds-father-404 · Answer

Cool that makes a lot of sense to want to optimize for Lower the friction with making rules readable

bitter-ability-32190 · Answer

OK <https github com pantsbuild pants pull 14238>