hundreds-father-404
01/24/2022, 11:43 PM[scalac].plugins_global
exists or not?3rdparty/jvm/global_scalac_plugins.lock
, whereas most tools default to <DEFAULT>
. https://github.com/pantsbuild/pants/pull/14241 means that we now error unless you manually generate the file.
The very simple fix is to set the default to be unsetwitty-crayon-22786
01/24/2022, 11:56 PMscalac_plugin
targets are set, it shouldn’t need to existhundreds-father-404
01/25/2022, 12:02 AMwitty-crayon-22786
01/25/2022, 12:03 AMhundreds-father-404
01/25/2022, 12:03 AMand Chris's new validation code already would error if your lockfile had entries but the tool is configured to have no artifactsAlthough, actually, this change would mean we don't catch that case. We would eagerly exit before reaching the validation. Is that fine?
it’s vaguely inconsistent for this option to have a default while others don’t, but i think that that ship has sailedThe others do have a default,
<default>
, which is the one we ship and Just Works. There's no meaningful <default>
for scalac-plugins
because it's an optional toolwitty-crayon-22786
01/25/2022, 12:04 AMversion
had defaulted, for example) to determine whether it should exist<default>
https://pantsbuild.slack.com/archives/C0D7TNJHL/p1643069038280100?thread_ts=1643067826.278200&cid=C0D7TNJHLhundreds-father-404
01/25/2022, 12:10 AMmaybe it is best to default to <default>If we do that, then we'd be loading a completely empty lockfile. Is that fine? It isn't wrong to do, just weird. It would make this code simpler & avoid the issue w/ unused lockfile
witty-crayon-22786
01/25/2022, 12:10 AMIf we do that, then we’d be loading a completely empty lockfile. Is that fine?from memory only, right? it wouldn’t be empty if you actually specified requirements
hundreds-father-404
01/25/2022, 12:11 AMimportlib.resources
.
it wouldn’t be empty if you actually specified requirementsIf that happens, we will eagerly error that the <defualt> is not compatible and you need to set a custom path. So, the <default> will always be empty
witty-crayon-22786
01/25/2022, 12:12 AM