any ideas for how to determine whether

Question

< witty crayon 22786> any ideas for how to determine whether we should check that ` scalac plugins global` exists or not

hundreds-father-404 · Answer

We default to it being `3rdparty jvm global scalac plugins lock` whereas most tools default to ` lt DEFAULT gt ` <https github com pantsbuild pants pull 14241> means that we now error unless you manually generate the file The very simple fix is to set the default to be unset

witty-crayon-22786 · Answer

if no `scalac plugin` targets are set it shouldn t need to exist

witty-crayon-22786 · Answer

otherwise it should

witty-crayon-22786 · Answer

so if <https www pantsbuild org docs reference scalac section plugins global> is empty the file needn t exist be validated

witty-crayon-22786 · Answer

but if it makes the code cleaner to remove the default location then ok just means people have to make multiple config edits to enable plugins

hundreds-father-404 · Answer

I could change the code to not read amp validate the lockfile if the tool is currently configured to have no artifacts That makes sense to me and Chris s new validation code already would error if your lockfile had entries but the tool is configured to have no artifacts

witty-crayon-22786 · Answer

yea sounds good then

witty-crayon-22786 · Answer

it s vaguely inconsistent for this option to have a default while others don t but i think that that ship has sailed

hundreds-father-404 · Answer

gt and Chris s new validation code already would error if your lockfile had entries but the tool is configured to have no artifacts Although actually this change would mean we don t catch that case We would eagerly exit before reaching the validation Is that fine

hundreds-father-404 · Answer

gt it s vaguely inconsistent for this option to have a default while others don t but i think that that ship has sailed The others do have a default ` lt default gt ` which is the one we ship and Just Works There s no meaningful ` lt default gt ` for `scalac plugins` because it s an optional tool

witty-crayon-22786 · Answer

i mean that they don t have a default lockfile location on disk

witty-crayon-22786 · Answer

even though user lockfiles do for consistency ease of use purposes

witty-crayon-22786 · Answer

i had suggested that tool lockfiles might have default locations as well and that we use some other property whether the `version` had defaulted for example to determine whether it should exist

witty-crayon-22786 · Answer

but that ship has probably sailed

witty-crayon-22786 · Answer

you re right that this is a bit sketchy would mean that you might have an unused lockfile with content in it sitting in the repo not the end of the world but combined with wanting consistency with other tools maybe it is best to default to ` lt default gt ` <https pantsbuild slack com archives C0D7TNJHL p1643069038280100 thread ts=1643067826 278200 amp cid=C0D7TNJHL>

hundreds-father-404 · Answer

gt maybe it is best to default to lt default gt If we do that then we d be loading a completely empty lockfile Is that fine It isn t wrong to do just weird It would make this code simpler amp avoid the issue w unused lockfile

witty-crayon-22786 · Answer

gt If we do that then we d be loading a completely empty lockfile Is that fine from memory only right it wouldn t be empty if you actually specified requirements

witty-crayon-22786 · Answer

yea it seems fine for the builtin lt default gt lockfile to be empty

hundreds-father-404 · Answer

Via `importlib resources` gt it wouldn t be empty if you actually specified requirements If that happens we will eagerly error that the lt defualt gt is not compatible and you need to set a custom path So the lt default gt will always be empty

witty-crayon-22786 · Answer

right