https://pantsbuild.org/ logo
#development
Title
# development
c

curved-television-6568

02/10/2022, 4:14 PM
h

hundreds-father-404

02/10/2022, 5:00 PM
Looks good! i think we should probably consolidate other sections into this tho, wdyt? Like the second half of https://www.pantsbuild.org/v2.10/docs/tagging-docker-images#tagging-images
1
c

curved-television-6568

02/10/2022, 5:48 PM
Ah, there it was.. I knew there was more places that talked about interpolation, but I searched for placeholder .. 😛
👍 1
Yeah, I’m not even sure if the “Tagging docker images” page is a good fit
There’s all kinds of stuff in there soon..:P
Feel free to move stuff around on those pages, if you have an idea you like
I can write, but I’m not very structured when it comes to docs.
h

hundreds-father-404

02/10/2022, 5:53 PM
I can spend some time next week thinking about it 🙂 will add it to the docs audit https://docs.google.com/spreadsheets/d/1wcddB4wjmtR1yhQ0UI46O_HMDOhQdYpmdjhk7myJxw0/edit#gid=1972664370 trying to knock out some stuff for 2.10.0rc1 today and tomorrow
💯 1
h

happy-kitchen-89482

02/10/2022, 8:28 PM
I'll take a stab at it , since I'm banging on docs today anyway
❤️ 2
Re this - it should probably list exactly which fields support interpolation and which values are available in each, in a table?
c

curved-television-6568

02/14/2022, 7:10 AM
Yeah, that makes sense.
I've setup the help for the fields such that all that support interpolation has a common wording for easy identification.
h

happy-kitchen-89482

02/14/2022, 3:56 PM
Great
But am I wrong that we already show examples of this interpolation before we get to that section of the docs?
c

curved-television-6568

02/14/2022, 4:36 PM
In the reference section, fields that support interpolation uses a wording such as “Each tag may use placeholders in curly braces to be interpolated. The placeholders are derived from various sources, such as the Dockerfile FROM instructions tags and build args.” Then in the docs there’s just the https://www.pantsbuild.org/docs/tagging-docker-images#setting-a-repository-name currently that refers to interpolation, I think (besides the new section in the 2.10 docs)
h

happy-kitchen-89482

02/14/2022, 4:51 PM
Doesn't "Using env vars to include dynamic data in tags" in that same page give interpolation examples?
"Setting a repository name" refers to interpolation in pants.toml, which is different
c

curved-television-6568

02/14/2022, 4:58 PM
Doesn’t “Using env vars to include dynamic data in tags” in that same page give interpolation examples?
Indeed it does. Bad search by me (was in a rush..)
h

happy-kitchen-89482

02/14/2022, 5:30 PM
OK, so I might tweak this to add something like "see more below" or whatever
I see that "Setting a repository name" links to the new section, but that refers to interpolation in pants.toml. Is that quite the same?
c

curved-television-6568

02/14/2022, 7:14 PM
What part refers to interpolation in pants.toml? The opening sentence in the new section “String interpolation using placeholder values” is
Some fields of the 
docker_image
 supports replacing placeholder values […]
Ah, gosh, my docs reading today is awful…
And yes, it’s the same. There’s even a hint at that in there…
In fact, you can use these placeholders in the 
repository
 field as well, if you find that helpful.
h

happy-kitchen-89482

02/16/2022, 1:06 AM
I think the new section looks good, I tweaked it only very slightly.
❤️ 1