FYI the pinned Toolchain plugin doesn't use the ne...
# developmentb
bitter-ability-32190
03/12/2022, 12:52 PMFYI the pinned Toolchain plugin doesn't use the new options types. I noticed when I started working on a PR to deprecate the old way 😉
f
fast-nail-55400
03/12/2022, 3:51 PMThe Toolchain plugin needs to work across a few different versions of Pants so will likely still need the old way of option registration for some time.
fast-nail-55400
03/12/2022, 3:52 PMOr will need some way of remaining compatible to old versions.
fast-nail-55400
03/12/2022, 3:53 PM(As you might guess, Toolchain users have different upgrade timelines for their own repos.)
p
polite-garden-50641
03/12/2022, 4:31 PMWhich version introduces the new options ? And what is the depreciation plan for the old ones ?
polite-garden-50641
03/12/2022, 4:32 PMAt any case, while working on the deprecation you can remove the plugin from the config
b
bitter-ability-32190
03/12/2022, 4:43 PMDeprecation in 2.11 and removal in 2.12 is the plan
bitter-ability-32190
03/12/2022, 4:43 PMAlso I don't think I can remove the plugin from the pants repo, which is where I saw the warning 😉
bitter-ability-32190
03/12/2022, 4:46 PMIt's a little nasty but you could always
if pants.versionelsep
polite-garden-50641
03/12/2022, 6:15 PMYou can just comment it out while you work on this change.
We are unable to upgrade to the latest 2.11 dev release in the Toolchain repo so I can't even start to work on this. Unfortunately.
b
bitter-ability-32190
03/12/2022, 6:53 PMOh it's not disruptive to me. And the change is minor. Mostly and fyi so we can decide how to handle.
I think I'll add a warning filter to pants' root toml so others don't see it 🙈
bitter-ability-32190
03/12/2022, 7:00 PMI can also send a diff you could apply if someone asks very nicely
bitter-ability-32190
03/13/2022, 1:50 AMbitter-ability-32190
03/13/2022, 1:56 AMI owe y'all a rewrite of the plugin options documentation. It'll be my next task
👍 1
p
polite-garden-50641
03/23/2022, 10:01 PMI expect to ship a version of the toolchain plugin that supports the new API early next week.
Once it is released and the pants repo is upgraded to using it, you will be able to remove the old APIs since the toolchain plugin will mo longer use them (in newer pants versions).
If you have a branch with the deprecation/removal of the API, please let me know since I can pull it down and test it with the new version of the plugin before releasing it.
b
bitter-ability-32190
03/23/2022, 10:29 PMI don't have the PR ready but it wouldn't be hard to while up. Just deleting the deprecated function
bitter-ability-32190
03/23/2022, 10:29 PMI'll post it when I get a spare minute or si