:fishing_pole_and_fish::four::man_feeding_baby::ba...
# developmentb
bitter-ability-32190
03/13/2022, 1:41 PM🎣4️⃣👨🍼🔙 on some PRs
Python asset inference: https://github.com/pantsbuild/pants/pull/14049
Deprecating
register_optionsbitter-ability-32190
03/13/2022, 5:23 PMIronically the new options code was forged out the fires of fury of renaming options from the asset inference PR a few times.
bitter-ability-32190
03/14/2022, 5:01 PM@happy-kitchen-89482 /@witty-crayon-22786 y'all have commented on the asset inference PR in the past 😉
w
witty-crayon-22786
03/14/2022, 5:19 PMVery exciting! I don't have any strong opinions about the string-asset one: fire away.
🔥 1
witty-crayon-22786
03/14/2022, 5:21 PMGreen light for the deprecation as well, but I can rubber stamp.
p
polite-garden-50641
03/15/2022, 1:01 AMAt least initially it should be off by default.I think this is the conservative approach that won't surprise users with unexpected behaviors.
See how it behaves with users (we can ask people to enable and report results back) and consider making a change to the default in a couple of releases once this feature is stabilized.
I don't think the pants repo itself is a good test case for this kind of feature (I.e. the fact that this works properly for pants is not a good indicator on how this will behave for users)
👍 1
b
bitter-ability-32190
03/15/2022, 1:04 AMFor clarification, you're talking asset inference, right? Not the "old" options deprecation?
p
polite-garden-50641
03/15/2022, 1:06 AMYes asset inference… again I might be writing in the wrong thread… I had a really long day 🤦♂️
b
bitter-ability-32190
03/15/2022, 1:06 AMI combined two tracks in one message. Blame me 😛
h
hundreds-father-404
03/15/2022, 1:17 AMYeah that's good feedback from Asher about waiting a full 2.11 relesae until we deprecate not setting a default for 2.12. Get some dogfooding first. Wdyt Joshua?
b
bitter-ability-32190
03/15/2022, 1:19 AMI'm for it. As long as it's in for my work repo I'm very happy.
❤️ 1
bitter-ability-32190
03/15/2022, 1:20 AMI can still brag about the feature anways 😤
🔥 1