https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

03/17/2022, 12:55 AM
Hey @witty-crayon-22786 I was trying to find previous conversations on moved_fields for non-file-based target generators like
pex_binaries
and couldn't find anything. What should we be doing there?
For example, I think the
dependencies
change you made would be good to apply to
python_requirements
too
Bump, probably worth figuring out before 2.11.0
w

witty-crayon-22786

03/17/2022, 11:34 PM
non-file generators are arbitrary code, and can do whatever they want… i defined `moved`/`copied` on
TargetGenerator
, but especially if non-file generators are going to be creating arbitrary other targets (as in that helm example) then it will make less sense to distinguish between the fields.
but… yea, this should be tightened up.
h

hundreds-father-404

03/17/2022, 11:56 PM
I think the notion is useful for all target generators, I like how it makes target generators simpler so that they're literally not more than a) a generator, and b) an alias to all the generated targets
w

witty-crayon-22786

03/18/2022, 12:08 AM
i’ll open a ticket.
❤️ 1
h

hundreds-father-404

03/18/2022, 12:16 AM
Thanks! I'm about to log off, but also reminder to us both that we should figure out plugin fields before stabilizing 2.11 so that
protobuf_sources
doesn't have an interpreter constraints field copied
w

witty-crayon-22786

03/18/2022, 12:17 AM
i’ve been marking things with the
2.11.x
milestone
👍 1