https://pantsbuild.org/ logo
Join Slack
Powered by
IMPORTANT: A single `category:` label is now requi...
# development
h
IMPORTANT: A single 
category:
label is now required on every PR
🎉 1
❗ 1
👀 2
👍 1
Once I merge https://github.com/pantsbuild/pants/pull/14855, this will be enforced. CI will fail if such a label is absent.
The label must be one of the following (already set up in GitHub): 
category:new feature
, 
category:user api change
, 
category:plugin api change
, 
category:performance
, 
category:bugfix
, 
category:documentation
, 
category:internal
This will soon be used to automatically generate the changelog, instead of the manual classification that happens today
b
Is it in the title or in the pr description? 👀
Good footnote to bring up at tomorrow's meeting! 🙃
h
It's a github label
So neither in the PR description or the title
🤯 1
h
that's great. this means you don't need to worry anymore about puttting 
[internal]
in the PR title
🙌 1
b
I like this change 🙂 The labels are very nice
❤️ 1
h
The upcoming release should be the last one that requires manual classification, as it straddles this change
after that we should be able to modify the release script to classify automatically
(with some pumping of the GitHub API to get the labels for each commit)
w
is adding a label supposed to re-kick the Checks automatically? it hasn’t (yet?) for https://github.com/pantsbuild/pants/pull/14878
(just re-started them manually)
h
No, it won't restart the checks, I don't know of a way to do that. But if you "Rerun all jobs" or "Rerun failed jobs" it'll pick up any newly added labels
👍 1
b
GHA are insanely customizable in terms of triggers.
h
But then it'll trigger on ANY label change, which is huge overkill
☝️ 1
b
There's probably some way to avoid re-running the task int hat instance with actions triggering actions, but perhaps that's getting into an overengineered solution
w
the fact that they just shipped “Restart only Failed Jobs” makes this less painful
👆 2
b
Can you make an action that triggers that behavior on label change?
Label error. Requires exactly 1 of
Why exactly 1 of? I have a PR that has a Plugin API change, a performance improvement, and a (little bit of) a User API change (output is changing)
h
These labels are for generating the changelog. Each change must go in exactly one section.
b
What happens if a Plugin API change is more performant? 🙈 I'll just bump mine down to Plugin API change then
h
Heh, yeah, that seems more important to highlight
b
I just want the glory of 
category:performance
Can we add a category for 
cosmetic
? One that doesn't change behavior, just UI. (Like fixing a typo, or making something colorized, etc...)
h
We've been (mis) labeling that as documentation
We could rename the category documentation and ux
b
For reference, this is what I need to label: https://github.com/pantsbuild/pants/issues/15059 (well the PR for that)
Open in Slack
PreviousNext
Powered by