https://pantsbuild.org/ logo
h

happy-kitchen-89482

03/20/2022, 10:51 PM
IMPORTANT: A single
category:
label is now required on every PR
๐ŸŽ‰ 1
โ— 1
๐Ÿ‘€ 2
๐Ÿ‘ 1
Once I merge https://github.com/pantsbuild/pants/pull/14855, this will be enforced. CI will fail if such a label is absent.
The label must be one of the following (already set up in GitHub):
category:new feature
,
category:user api change
,
category:plugin api change
,
category:performance
,
category:bugfix
,
category:documentation
,
category:internal
This will soon be used to automatically generate the changelog, instead of the manual classification that happens today
b

bitter-ability-32190

03/20/2022, 11:46 PM
Is it in the title or in the pr description? ๐Ÿ‘€
Good footnote to bring up at tomorrow's meeting! ๐Ÿ™ƒ
h

happy-kitchen-89482

03/21/2022, 12:37 AM
It's a github label
So neither in the PR description or the title
๐Ÿคฏ 1
h

hundreds-father-404

03/21/2022, 2:30 PM
that's great. this means you don't need to worry anymore about puttting
[internal]
in the PR title
๐Ÿ™Œ 1
b

bitter-ability-32190

03/22/2022, 12:59 AM
I like this change ๐Ÿ™‚ The labels are very nice
โค๏ธ 1
h

happy-kitchen-89482

03/22/2022, 4:25 PM
The upcoming release should be the last one that requires manual classification, as it straddles this change
after that we should be able to modify the release script to classify automatically
(with some pumping of the GitHub API to get the labels for each commit)
w

witty-crayon-22786

03/22/2022, 11:00 PM
is adding a label supposed to re-kick the Checks automatically? it hasnโ€™t (yet?) for https://github.com/pantsbuild/pants/pull/14878
(just re-started them manually)
h

happy-kitchen-89482

03/23/2022, 4:17 AM
No, it won't restart the checks, I don't know of a way to do that. But if you "Rerun all jobs" or "Rerun failed jobs" it'll pick up any newly added labels
๐Ÿ‘ 1
b

bitter-ability-32190

03/23/2022, 1:15 PM
GHA are insanely customizable in terms of triggers.
h

happy-kitchen-89482

03/23/2022, 9:08 PM
But then it'll trigger on ANY label change, which is huge overkill
โ˜๏ธ 1
b

bitter-ability-32190

03/23/2022, 9:12 PM
There's probably some way to avoid re-running the task int hat instance with actions triggering actions, but perhaps that's getting into an overengineered solution
w

witty-crayon-22786

03/23/2022, 9:31 PM
the fact that they just shipped โ€œRestart only Failed Jobsโ€ makes this less painful
๐Ÿ‘† 2
b

bitter-ability-32190

03/23/2022, 9:45 PM
Can you make an action that triggers that behavior on label change?
Label error. Requires exactly 1 of
Why exactly 1 of? I have a PR that has a Plugin API change, a performance improvement, and a (little bit of) a User API change (output is changing)
h

happy-kitchen-89482

03/24/2022, 2:58 PM
These labels are for generating the changelog. Each change must go in exactly one section.
b

bitter-ability-32190

03/24/2022, 3:13 PM
What happens if a Plugin API change is more performant? ๐Ÿ™ˆ I'll just bump mine down to Plugin API change then
h

happy-kitchen-89482

03/24/2022, 3:57 PM
Heh, yeah, that seems more important to highlight
b

bitter-ability-32190

03/24/2022, 4:00 PM
I just want the glory of
category:performance
Can we add a category for
cosmetic
? One that doesn't change behavior, just UI. (Like fixing a typo, or making something colorized, etc...)
h

hundreds-father-404

04/08/2022, 1:22 AM
We've been (mis) labeling that as documentation
We could rename the category documentation and ux
b

bitter-ability-32190

04/08/2022, 12:51 PM
For reference, this is what I need to label: https://github.com/pantsbuild/pants/issues/15059 (well the PR for that)