IMPORTANT A single `category ` label is now required on ever

Question

IMPORTANT A single `category ` label is now required on every PR

happy-kitchen-89482 · Answer

Once I merge <https github com pantsbuild pants pull 14855> this will be enforced CI will fail if such a label is absent

happy-kitchen-89482 · Answer

The label must be one of the following already set up in GitHub `category new feature` `category user api change` `category plugin api change` `category performance` `category bugfix` `category documentation` `category internal`

happy-kitchen-89482 · Answer

This will soon be used to automatically generate the changelog instead of the manual classification that happens today

bitter-ability-32190 · Answer

Is it in the title or in the pr description eyes

bitter-ability-32190 · Answer

Good footnote to bring up at tomorrow s meeting upside down face

happy-kitchen-89482 · Answer

It s a github label

happy-kitchen-89482 · Answer

So neither in the PR description or the title

hundreds-father-404 · Answer

that s great this means you don t need to worry anymore about puttting ` internal ` in the PR title

bitter-ability-32190 · Answer

I like this change slightly smiling face The labels are very nice

happy-kitchen-89482 · Answer

The upcoming release should be the last one that requires manual classification as it straddles this change

happy-kitchen-89482 · Answer

after that we should be able to modify the release script to classify automatically

happy-kitchen-89482 · Answer

with some pumping of the GitHub API to get the labels for each commit

witty-crayon-22786 · Answer

is adding a label supposed to re kick the Checks automatically it hasn t yet for <https github com pantsbuild pants pull 14878>

witty-crayon-22786 · Answer

just re started them manually

happy-kitchen-89482 · Answer

No it won t restart the checks I don t know of a way to do that But if you Rerun all jobs or Rerun failed jobs it ll pick up any newly added labels

bitter-ability-32190 · Answer

You could have it trigger on label change <https docs github com en actions using workflows events that trigger workflows label>

bitter-ability-32190 · Answer

GHA are insanely customizable in terms of triggers

happy-kitchen-89482 · Answer

But then it ll trigger on ANY label change which is huge overkill

bitter-ability-32190 · Answer

There s probably some way to avoid re running the task int hat instance with actions triggering actions but perhaps that s getting into an overengineered solution

witty-crayon-22786 · Answer

the fact that they just shipped Restart only Failed Jobs makes this less painful

bitter-ability-32190 · Answer

Can you make an action that triggers that behavior on label change

bitter-ability-32190 · Answer

gt Label error Requires exactly 1 of Why exactly 1 of I have a PR that has a Plugin API change a performance improvement and a little bit of a User API change output is changing

bitter-ability-32190 · Answer

for reference <https github com pantsbuild pants pull 14903>

happy-kitchen-89482 · Answer

These labels are for generating the changelog Each change must go in exactly one section

bitter-ability-32190 · Answer

What happens if a Plugin API change is more performant see no evil I ll just bump mine down to Plugin API change then

happy-kitchen-89482 · Answer

Heh yeah that seems more important to highlight

bitter-ability-32190 · Answer

I just want the glory of `category performance`

bitter-ability-32190 · Answer

Can we add a category for `cosmetic` One that doesn t change behavior just UI Like fixing a typo or making something colorized etc

hundreds-father-404 · Answer

We ve been mis labeling that as documentation

hundreds-father-404 · Answer

We could rename the category documentation and ux

bitter-ability-32190 · Answer

For reference this is what I need to label <https github com pantsbuild pants issues 15059|https github com pantsbuild pants issues 15059> well the PR for that