Somehow I merged a cherry pick on mobile with the ...
# developmentb
bitter-ability-32190
04/12/2022, 9:56 PMSomehow I merged a cherry pick on mobile with the checks failing https://github.com/pantsbuild/pants/pull/15115
I'll revert tonight after the kids go down
Should those branches be protected?
h
hundreds-father-404
04/12/2022, 9:56 PMThey cannot be protected because it breaks our release process
hundreds-father-404
04/12/2022, 9:57 PMI got you. I will put up a revert
b
bitter-ability-32190
04/12/2022, 9:58 PMI'll be more careful with my picking then
h
hundreds-father-404
04/12/2022, 9:58 PMhundreds-father-404
04/12/2022, 10:00 PMBy the way, it is better to not merge on a broken branch. It will cause CI to fail on the build after merge.
b
bitter-ability-32190
04/12/2022, 10:02 PMCherry picking is hard, let's go shopping
🛍️ 1
💯 1
h
hundreds-father-404
04/12/2022, 10:03 PMI am always down to shop shop shop 🛍️
b
bitter-ability-32190
04/13/2022, 12:31 AMbitter-ability-32190
04/13/2022, 12:59 AMh
hundreds-father-404
04/13/2022, 1:00 AMI hate cherry picks
hundreds-father-404
04/13/2022, 1:00 AMugh
b
bitter-ability-32190
04/13/2022, 1:00 AM😂
bitter-ability-32190
04/13/2022, 1:00 AMFWIW https://github.com/pantsbuild/pants/pull/15117 makes this slightly easier
❤️ 1
bitter-ability-32190
04/13/2022, 1:01 AM(IIRC I like in Azure DevOps there was dedicated "cherry-pick" button)