Anyone here familiar with using TCP/IP sockets during tests in our CI runs? I have an integration test for the GraphQL API that works locally, but in CI it doesn’t seem to work. (I’ve opted to short-cut this particular test for now, but will revisit again)

(Semi related I was hoping to mock the network calls in our tests, because network calls in unit tests can be unreliable.)

For the unit tests, I plan to use mock stuff, but this was for an integration test, so kind of takes away the test to mock it there 😛

How does it fail in CI? Do you have any logs?

Yup: https://github.com/pantsbuild/pants/runs/6740649892?check_suite_focus=true

E           requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=7908): Max retries exceeded with url: /graphql (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f3234661f90>: Failed to establish a new connection: [Errno 111] Connection refused'))
/home/runner/.cache/pants/named_caches/pex_root/venvs/s/aad82963/venv/lib/python3.7/site-packages/requests/adapters.py:519: ConnectionError

I’d check whether the test server actually bound its port.

(the version linked passes in CI, as I don’t attempt the network call if the backend didn’t start properly)|

is the GraphQL server a BuiltinGoal?

It seems it didn’t, so that check wouldn’t tell me much? are you suggesting that the selected port is not available, though perhaps..?

you marked the test with

pytest.mark.parametrize

, is pytest executing each paramterized test in parallel?

well, there’s just one parametrization in there, so no, don’t think so (great idea, though)

FWIW I don't think pytest does any parallelization. All that comes from extra plugins.

I’d suggest dumping logs from that pants process. Just spawn two threads to read from the process stdout/stderr respectively and dump to the console.

yeah, that’ll be the next step debugging it..

We have lots of tests that bind TCP ports and never had any problems with GHA firewalling anything.

right, ok. thanks. good to know.