Also, how important do we think the `flake8_pantsb...
# developmentb
bitter-ability-32190
06/11/2022, 4:00 PMAlso, how important do we think the `flake8_pantsbuild`'s "constant-in-a-conditional" check really is? It's the only checks enabled in Pants (the other checks are disabled locally or by the plugin itself).
E.g.
Copy code
if True or x:
...
if x and False:
...bitter-ability-32190
06/13/2022, 12:01 AMI ask because I was planning on porting the plugin to be first-party, but thats all we use.
Thinking we should just toss the plugin altogether
h
hundreds-father-404
06/13/2022, 6:08 PMthe main reason the plugin exists is because back in the day, Pants v1 didn't run Flake8. It was its own combination of some Flake8 lints (pycodestyle iirc) + custom Pants lints
We only did that plugin to not break our deprecation policy
hundreds-father-404
06/13/2022, 6:10 PMWhat's your proposal? Yank from PyPI? Right now the plugin is not actively maintained
b
bitter-ability-32190
06/13/2022, 6:14 PMWe don't have to yank, but we can archive the repo and stop using it in house
👍 1
bitter-ability-32190
06/15/2022, 1:04 AM