https://pantsbuild.org/ logo
#development
Title
# development
c

curved-television-6568

06/13/2022, 3:06 PM
New discussion on a proposed design doc for adding a
__defaults__
construct in BUILD files: https://github.com/pantsbuild/pants/discussions/15809
πŸŽ‰ 2
βœ… 2
πŸ”₯ 2
πŸ™Œ 2
🎣 for feedback πŸ˜‰
h

hundreds-father-404

06/13/2022, 4:51 PM
Ohhh I like this a lot, that you use a specific construct rather than a
python_sources
target overriding a
python_sources
target etc. There is still only one target owner per entity FYI this is similar to the
overrides
proposal https://docs.google.com/document/d/1bcQRJazx6ODKc0PZRUgPx_bqHc6XurpBawTMD2zhtAk/edit. I like this a lot more because the semantics are so clear: this solely impacts the default
c

curved-television-6568

06/13/2022, 5:58 PM
Thanks. Yea saw the similarities with overrides as well.
w

witty-family-13337

06/13/2022, 7:25 PM
love this, we’re using macros to propagate defaults to different areas of the codebass, this would help getting rid of them
πŸ‘ 2
b

bitter-ability-32190

06/13/2022, 7:34 PM
Yeah super duper strong +10 from me 😭
❀️ 2
h

hundreds-father-404

06/13/2022, 8:04 PM
+100 from me. You avoid all the concerns I had with prior proposals for hierarchical metadata. The main thing I love is this only changes the default value; and you aren't creating any new targets
❀️ 1
w

witty-crayon-22786

06/14/2022, 5:46 PM
this is really exciting! will try to take a look this afternoon.
πŸ‘ 1