https://pantsbuild.org/ logo
Powered by
h

happy-kitchen-89482

06/16/2022, 9:52 PM
We have quite a few cases in the codebase of WrappedTargetRequest with 
description_of_origin="<infallible>"
What does that mean? It's not very instructive to the end user
c

curved-television-6568

06/16/2022, 10:07 PM
I agree, but I think the intention is that it should never happen.
That is, “it can not fail” and as such, will never end up in a user facing message..
h

happy-kitchen-89482

06/16/2022, 10:13 PM
It literally is happening, that's how I found it
😲 1
Let's see if I can make a self-contained repro
w

witty-crayon-22786

06/16/2022, 10:23 PM
at least for 2.13, we’ll want to fix those when we spot them. but i’m hoping (see https://pantsbuild.slack.com/archives/C0D7TNJHL/p1654605400998769 and https://github.com/pantsbuild/pants/pull/15789#pullrequestreview-1000533318) that we can remove/revert a lot of them in 2.14
h

hundreds-father-404

06/16/2022, 10:28 PM
where is it happening?
h

happy-kitchen-89482

06/16/2022, 11:07 PM
It was when 
!!
excluding a file in the dependencies of a pex_binary, and I had a copypasta error in the target name
Stack trace:
Copy code
23:56:50.71 [ERROR] 1 Exception encountered:

Engine traceback:
  in select
  in pants.core.goals.package.package_asset
  in pants.backend.python.goals.package_pex_binary.package_pex_binary (py/apps/pyapp:venv)
  in pants.engine.internals.graph.transitive_targets
  in pants.engine.internals.graph.resolve_targets
  in pants.engine.internals.graph.resolve_unexpanded_targets
  in pants.engine.internals.graph.resolve_target
  in pants.engine.internals.graph.resolve_target_parametrizations (py/libs/nufft:pybind0)
  in pants.engine.internals.build_files.find_target_adaptor (py/libs/nufft:pybind0)
Traceback (most recent call last):
  File "/Users/benjyw/src/pants/src/python/pants/engine/internals/selectors.py", line 705, in native_engine_generator_send
    res = func.send(arg)
  File "/Users/benjyw/src/pants/src/python/pants/engine/internals/build_files.py", line 172, in find_target_adaptor
    namespace=address_family.namespace,
pants.build_graph.address.ResolveError: The address py/libs/nufft:pybind0 from <infallible> does not exist.

The target name ':pybind0' is not defined in the directory py/libs/nufft. Did you mean one of these target names?

  * :nufft
  * :nufft0
  * :nufft_dist
  * :nufft_files
  * :pyproject
h

hundreds-father-404

06/16/2022, 11:08 PM
Okay, thanks
h

happy-kitchen-89482

06/16/2022, 11:10 PM
I can't quite repro trivially though
Will try more if this isn't helpful enough
h

hundreds-father-404

06/16/2022, 11:15 PM
it's not reproducible? Or you don't have the same setup anymore?
h

happy-kitchen-89482

06/16/2022, 11:17 PM
It's reproducible in some specific set of circumstances in some repo
I haven't managed to repro it with like a one line change in pantsbuild/pants
So I don't know what particular house of cards leads to this
h

hundreds-father-404

06/16/2022, 11:18 PM
Excellent find. Thanks! Fix upcoming
Fixed 🙂
The address 
src/python/pants/util/strutil_test.py
from the 
dependencies
field from the target src/python/pants/util/strutil_test.py:tests was not generated by the target 
src/python/pants/util:util
. Did you mean one of these addresses?
🙏 1
Powered by