https://pantsbuild.org/ logo
Join Slack
Powered by
it sounds like we’re on for `2.13.0a0` tomorrow
# development
w
it sounds like we’re on for 
2.13.0a0
tomorrow
@average-vr-56795 is on release duty (thanks! see the 2.12 docs for more info on 
a
(alpha) releases)
👍 1
@hundreds-father-404, @fast-nail-55400: i’m hoping to get https://github.com/pantsbuild/pants/pull/15850 (and its deps) landed before we cut, but if that’s controversial, hopefully we can discuss cherry-picking it.
h
I'm fine including it. I was waiting to review the last one until the first two landed
w
thanks. i can make a bunch of docs and help changes once we’re in agreement on the shape of the flags
h
oh didn't see that you had responded to my other comments/questions! yeah I'm fine punting on docs changes
w
yea, to be clear: happy to make the edits in these PRs: was just waiting for some consensus on the deprecations/additions
h
I'm about to leave on hike w/ sister. I think if we land commit 4, it should be a dedicated PR marked "User API change" -- Want me to hit approve on 15854 before I leave, w/ understanding commit 4 would be split out?
w
no urgency: i’m done for the day too. enjoy!
👍 1
f
My only concern with the whole stack is having three different option for REAPI endpoints. Bazel just has 
--remote_cache
and 
--remote_executor
options with no way to configure a different store address.
👍 1
(And I don’t have much preference on how the remainder of the stack looks.)
w
ok. if we really don't think that the flag is likely to be usable in prod, then I can take a swing at merging the StubCAS and StubActionCache. the rust code never needed them to run on the same address, since it configured them piecemeal
👍 1
b
Just a head sup, I think we should land https://github.com/pantsbuild/pants/pull/15849 before release. I'll work on getting it out of draft mode tonight, but there's already two or three hotspots I see for discussion
👍 1
(The reasoning is it reverts a feature we haven't released yet, so I'd rather us not release-then-deprecate 😅 )
h
@bitter-ability-32190 what if we only revert the unreleased feature? I'm concerned with rushing https://github.com/pantsbuild/pants/pull/15849 -- it's an amazing change I'm very excited to approve. Although it's a complex change w/ implications for deprecation policy
b
Yeah, I was holding onto that in my back pocket 😉
I'd want @happy-kitchen-89482’s approval at least
a
@bitter-ability-32190 Do you think that's likely to land today, or should we aim for a cherry-pick after?
b
Not landing today, for aure
a
👍
Would you like me to hold off for a bit, or shall I start kicking it off?
w
i’m expecting https://github.com/pantsbuild/pants/pull/15850 to land shortly: if you’re able to wait for that, it would be appreciated!
but yea, i think everything else in https://github.com/pantsbuild/pants/milestone/54 is cherry-pickable
#15850 just landed. thanks again!
a
Fabulous! Yeah, I was watching that one :) will kick stuff off now!
Open in Slack
PreviousNext
Powered by