hm. i don’t think that the rust tests are running on main. just saw a test compilation failure during a cherry-pick to 2.13.

our skipping logic is def faulty

in this case, i’m sure it was due to my rebases or something. but yea, the CI portion of the skips should almost certainly check all of the commits in a branch, rather than the top one

it checks based on the merge base iirc, so your most recent push

should use the merge-base with main… that’s exactly the PR’s commits

We ~know how to skip with in-CI logic now (since we're doing it for docs-only changes)

Hmm did this lead to this failure? https://github.com/pantsbuild/pants/runs/7307810181?check_suite_focus=true error[E0425]: cannot find function

update_env

in module

local

--> process_execution/src/local_tests.rs35710 | 357 | local::update_env(&work_dir.path(), &mut req);

|          ^^^^^^^^^^ not found in `local`

yes