https://pantsbuild.org/ logo
#development
Title
# development
h

happy-kitchen-89482

07/27/2022, 2:54 PM
@bitter-ability-32190 Did your pex_binary running changes alter the CWD of the sandboxed run? It should be the repo root, but I'm not sure it is now?
b

bitter-ability-32190

07/27/2022, 2:59 PM
How are you measuring this? The default after my changes is the same pre-my changes. I'm not sure it messes with CWD at all. The sandbox is in the sys path via the
[pythom].default_run_goal_use_sandbox
option, or via the
run_goal_use_sandbox
field on that target
w

witty-crayon-22786

07/27/2022, 4:18 PM
hm: yea, the behavior change is more subtle than the
cwd
it looks like. we’ll have to work up a repro.
👀 1
b

bitter-ability-32190

07/27/2022, 4:19 PM
FWIW the code should've been a 1:1 copy of the code pre-my change. I just lifted it to a helper 🙈
should
w

witty-crayon-22786

07/27/2022, 6:29 PM
will bisect within the range. but seems just as likely to have been PEX changes.
b

bitter-ability-32190

07/27/2022, 7:26 PM
Looks like John chimed in with the same thought I had w.r.t. what changed
w

witty-crayon-22786

07/27/2022, 7:29 PM
i’ll probably resume looking at it tomorrow, but without yet having actually looked at any of the links that John posted, my first reaction is: “this case shouldn’t need
--no-strip-pex-env
, since there shouldn’t be any pex path shenangians for this case”
w

witty-crayon-22786

07/27/2022, 8:33 PM
yea