Any opposition to keeping ` python resolve all constraints`

Question

Any opposition to keeping ` python resolve all constraints` until Pants 3 0 but deprecated Originally the plan was to remove it

hundreds-father-404 · Answer

We ve had so much whiplash with Python lockfiles it seems like a good courtesy for users Because it s deprecated it will be clear new users should avoid it I ve finished refactoring thanks to rule helper so the impact to understanding `pex from targets py` is actually pretty minimal now Note that we will always need to keep around a lot of the relevant code with how to subset via ` repository pex` because we decided to support manually managed requirements txt style locks

hundreds-father-404 · Answer

cc < witty crayon 22786> and < bitter ability 32190> who I think were both looking forward to deleting the code along with me and cc < flat zoo 31952> and < enough analyst 54434> who I imagine will agree w keeping it

enough-analyst-54434 · Answer

Always favor the user They have real problems we just whine as developers

witty-crayon-22786 · Answer

deprecation length is a very nuanced tool how to choose `2 N+1` vs `3` is unclear but is something that i think < flat zoo 31952> was going to be looking into based on the audience

witty-crayon-22786 · Answer

this is not an end user facing feature rather an admin maybe that influences this

hundreds-father-404 · Answer

let s say we choose 3 0 today but realize in a year that this feature blocks some important change Thoughts if we could change the deprecation from 3 0 to 2 40 etc given several releases for that to happen

witty-crayon-22786 · Answer

but if there is not a concrete upcoming feature that will motivate further changes to `pex from targets` i wouldn t be hunting for things to deprecate anyway

enough-analyst-54434 · Answer

I personally consider them the same Only big orgs have the differentiation

enough-analyst-54434 · Answer

Hopefully we support the little guys too

hundreds-father-404 · Answer

gt this is not an end user facing feature rather an admin maybe that influences this I think the most important thing here is that 3rd party requirements are complex and frustrating to deal with We shouldn t force you to migrate but we should encourage you to use the newer and safer thing

witty-crayon-22786 · Answer

gt I personally consider them the same Only big orgs have the differentiation i don t think that that is true if a team of folks work in a monorepo only one of them is going to land the upgrade PR

witty-crayon-22786 · Answer

to the extent that we are used by single person teams then maybe

enough-analyst-54434 · Answer

And if a team is a team of 5 they all work on the build I do not discount small

witty-crayon-22786 · Answer

not in my experience even at that size you have specialists but regardless i don t think that that means admin vs end user is not a useful consideration just that it becomes less useful for very small teams grey area

flat-zoo-31952 · Answer

I think everyone will have some version of admin vs user even small teams will have 1 or 2 team members that get it much more and drive adoption perform upgrade cycles decide how Pants gets used But even admin only deprecations should be motivated by concrete issues either data showing the item is legitimately a misfeature or if it directly conflicts with progress this is what i m going to recommend anyways

witty-crayon-22786 · Answer

gt either data showing the item is legitimately a misfeature or if it directly conflicts with progress yea

flat-zoo-31952 · Answer

I am this admin for a large ish org and it still takes me time to my head around changes even ones that are fully backwards compatible and unambiguously positive Just learning I can do things a new way takes time So no matter the user type we should try to make life easy on them

hundreds-father-404 · Answer

gt either data showing the item is legitimately a misfeature or if it directly conflicts with progress misfeature no it s valid only much worse than ` python enable resolves` progress not really only makes our code harder to deal with but it s factored well now

hundreds-father-404 · Answer

Thanks for the input <https github com pantsbuild pants pull 16606>