https://pantsbuild.org/ logo
Powered by
b

busy-vase-39202

09/02/2022, 7:06 PM
My contributions to in-repo docs were merged to 
main
but don't seem to be overwriting the older versions of those pages that were in readme. Does the readme page need to be deleted in order for its in-repo version to take over?
a

ancient-vegetable-10556

09/02/2022, 7:07 PM
doc updates do not appear automatically, they need to be manually pushed by someone — usually @hundreds-father-404
in a pinch, I could do it, but it’s not an automatic process
b

busy-vase-39202

09/02/2022, 7:08 PM
Ah. Would someone please trigger the push? I'm blocked on announcing these until they're on the public site.
a

ancient-vegetable-10556

09/02/2022, 7:09 PM
note that 
main
is docs for a future release of pants, and you’ll need to have the changes cherry-picked to the current release version for them to show up there. Has that been done yet, or do you need that too?
b

busy-vase-39202

09/02/2022, 7:09 PM
In the future, should I make a habit of requesting the docs push when I have a docs PR land on 
main
?
Yep, Eric took care of cherry-picking them.
a

ancient-vegetable-10556

09/02/2022, 7:11 PM
which branches do I need to take care of?
h

hundreds-father-404

09/02/2022, 7:12 PM
2.12 - 2.14. i think you will get an error about missing category and need to manually create the page first for the docs update to work (which is why I've been punting on it, tedious to do)
a

ancient-vegetable-10556

09/02/2022, 7:13 PM
is there a current version readme for 
main
?
b

busy-vase-39202

09/02/2022, 7:13 PM
Is this meta I didn't know to add and can go retcon, or something only you can do?
h

hundreds-father-404

09/02/2022, 7:15 PM
no, 
main
branch from github is ignored. we haven't yet forked 2.15. Benjy pushed back when I forked 2.14 "too early"
Is this meta I didn't know to add and can go retcon, or something only you can do?
it would be a big help if you are able to do. in readme.com's website, you create the page for each version you want. you've already done this, but only on 2.12. Need to add to 2.13 and 2.14
👍 1
a

ancient-vegetable-10556

09/02/2022, 7:16 PM
I’ve added the page to 2.13
and am adding it to 2.14
h

hundreds-father-404

09/02/2022, 7:16 PM
this is only necessary when creating a new page
b

busy-vase-39202

09/02/2022, 7:20 PM
Ah, gotcha. I created the page on readme only because Benjy said it was needed to get a slug for the markdown doc's meta headers. I hadn't been aware that more was needed on the readme side.
h

hundreds-father-404

09/02/2022, 7:21 PM
That was correct what you did: the only missing step was then creating that page on 2.13 and 2.14 as well
b

busy-vase-39202

09/02/2022, 7:21 PM
Can't wait to be out of this awkward transitional state where we still have all the constraints of readme holding things back.
Powered by