https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

09/02/2022, 8:07 PM
looks like
main
is broken: getting a PR out shortly.
...hm. they pass locally.
…ah. disabled on macOS
@fast-nail-55400: missed that in the initial review. those test should be runnable on macOS, right?
yea, they seem to be.
f

fast-nail-55400

09/02/2022, 8:18 PM
they are runnable on macOS if Docker is installed and running
đź‘Ť 1
I had to make it skip on macOS if Docker is not running because macOS runners in CI do not have Docker
w

witty-crayon-22786

09/02/2022, 8:18 PM
got it.
f

fast-nail-55400

09/02/2022, 8:19 PM
see the
setup_docker
macro in
<http://docker_tests.rs|docker_tests.rs>
for particulars
w

witty-crayon-22786

09/02/2022, 8:19 PM
yea, i removed the check there and things worked. but the CI aspect makes sense. i won’t change it here, but could maybe be disabled via an env var or feature or something
thanks!
@fast-nail-55400: one bit that i don’t understand is just that it looks like they weren’t running even when docker was actually up and connectable. maybe i didn’t wait long enough before starting them.
anywho. thanks
f

fast-nail-55400

09/02/2022, 8:30 PM
the error is:
docker_image not set on the Process, but the Docker CommandRunner was used
the tests probably need to be updated to set this new attribute ...
w

witty-crayon-22786

09/02/2022, 8:31 PM
yea, see the PR i pushed. already fixed.
i was just talking about the skip-on-macOS-but-only-if-fail-to-connect capability seemingly having had a false positive on my machine. but maybe i didn’t wait long enough after starting docker.
h

hundreds-father-404

09/02/2022, 8:37 PM
thank you for fixing