https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

09/14/2022, 9:31 PM
Mini proposal for inverting how we mark processes platform-agnostic: https://github.com/pantsbuild/pants/issues/16873
@witty-crayon-22786 I don't know how to reason about my suspicion that
docker_image
currently messes up caching, that Docker command runner won't use the cache from localhost. That seemed to be the case when playing with things last week Does the
Process
struct play into local cache? Or it's only the REAPI proto and ActionCache stuff, right?
…where
make_execute_request
is also what we use to produce an ExecuteRequest/Action for remote caching/execution
that Docker command runner won’t use the cache from localhost
to prevent cache hits across localhost and docker for an otherwise identical process, you’d want to update
make_execute_request
to produce a different request when a docker image is set… usually via an environment variable
(assuming that what you are saying is that you’re seeing hits when you don’t want to be…?)
but including the platform should also be sufficient to prevent that hit, i think
👍 1
(commented on the ticket)
h

hundreds-father-404

09/14/2022, 10:12 PM
okay cool I will remove the
docker_image
stuff then from the issue. This proposal makes sense regardless imo