hundreds-father-404
09/15/2022, 12:17 AMfast-nail-55400
09/15/2022, 12:25 AMfast-nail-55400
09/15/2022, 12:26 AMhundreds-father-404
09/15/2022, 12:26 AMfast-nail-55400
09/15/2022, 12:28 AMhundreds-father-404
09/15/2022, 12:33 AMfast-nail-55400
09/15/2022, 12:37 AMwitty-crayon-22786
09/15/2022, 12:39 AMwitty-crayon-22786
09/15/2022, 12:39 AMfast-nail-55400
09/15/2022, 12:39 AMrust:1.63.0
) which sets CARGO_HOME
and RUSTUP_HOME
. Why should Pants supply those values?witty-crayon-22786
09/15/2022, 12:39 AMVarious contexts will then set or reset some of those env vars
...which might override the vars set inside the image.
witty-crayon-22786
09/15/2022, 12:41 AMwitty-crayon-22786
09/15/2022, 12:41 AMhappy-kitchen-89482
09/15/2022, 1:32 AMhappy-kitchen-89482
09/15/2022, 1:32 AMhundreds-father-404
09/15/2022, 3:01 AMif every user uses the same image, then the env vars would be the same for all of the users, right?Alright that now makes sense to me to not strip. https://github.com/pantsbuild/pants/pull/16876 and https://github.com/pantsbuild/pants/issues/16877 only downside imo is not having parity with local environments. But that seems like a weak reason to force users to add a bunch of boilerplate to enable env vars they would reasonably expect to be enabled
fast-nail-55400
09/15/2022, 3:06 AMIsn’t the image identity part of the cache key?Unclear to me how we account for it currently. It is easy enough to retrieve the SHA256 hash of the image and use that value somewhere.
witty-crayon-22786
09/15/2022, 3:21 AM