curved-television-6568
09/16/2022, 6:57 PM--changed-since
flag which is one of the (many) most awesome features in Pants, and realize that Iām missing a dependency on a targets lockfile for each resolve it is a part of.requirements.txt
file, which is all well and good, but it is actually the lockfile that is relevant.busy-vase-39202
09/16/2022, 7:00 PMbah, kbd, slip
is" which tells you how close my brain is to weekend mode...curved-television-6568
09/16/2022, 7:00 PMbusy-vase-39202
09/16/2022, 7:01 PMcurved-television-6568
09/16/2022, 7:02 PMI assumed youād be kept busy by imanage for a good while.I am š š
hundreds-father-404
09/16/2022, 7:07 PM_generator_sources_helper
target for the lockfile. There is no natural place to generate that. Whereas python_requirements
can generate it for its source
fieldenough-analyst-54434
09/16/2022, 7:14 PMhundreds-father-404
09/16/2022, 7:16 PM.isort.cfg
should invalidate all Python targets where skip_isort=False
, but it doesn't. --changed-since
is imperfect and we say that in the docscurved-television-6568
09/17/2022, 12:45 AMfile
target for the lock file and a dependency from the python_requirements
to that, but I donāt want the lock file to actually be pulled into anything package wise, only used as a means to get targets to work on for the changed since option.experimental_shell_command
could work as go between, as a filter..hundreds-father-404
09/19/2022, 3:12 PM_generator_sources_helper
target type, which has a source
fieldcurved-television-6568
09/19/2022, 3:48 PMhundreds-father-404
09/19/2022, 3:49 PMcurved-television-6568
09/19/2022, 3:56 PMThat would be tricky to pull off because no ātarget generatorsā can synthesize aWhat if thetarget for the lockfile. There is no natural place to generate that. Whereas_generator_sources_helper
can generate it for itspython_requirements
fieldsource
python_requirements
generator also generates a _generator_sources_helper
for each resolve
as a resolve requires a lockfile, that should be fine! (and skip that if resolves are not enabled, naturally) Itās just a matter of looking up the lockfile path for the each resolve._generator_sources_helper
explicitly in the BUILD file, as I canāt add the dependency in a clean way)> I still have no idea how weād solve it, but at least worth documenting as an issue
I can create a ticket later tonight (Itās a hassle to switch between GH accounts, as I have another one for iManage work)https://github.com/pantsbuild/pants/pull/16934 @hundreds-father-404 Iād love some š on this (when convenient), and would like picking to 2.14.x if at all possible š
hundreds-father-404
09/21/2022, 5:08 PM