bah, kbd slip.. 😛

… well, I’m considering the

--changed-since

flag which is one of the (many) most awesome features in Pants, and realize that I’m missing a dependency on a targets lockfile for each resolve it is a part of.

There is a dependency to the

requirements.txt

file, which is all well and good, but it is actually the lockfile that is relevant.

as the contents of the lockfile may change without touching the requiremnts file.

I assumed you’d be kept busy by imanage for a good while.

I am 🙂 😄

I want targets gone as much as possible, but if they are required for the current implementation of --changed then that seems to need fixing 1st.

OK, got an idea how to potentially solve this, I’ll just need to find some time to test it see how it falls out 🙂

But, in the mean time is there a way to manually add this dependency link? like adding a

file

target for the lock file and a dependency from the

python_requirements

to that, but I don’t want the lock file to actually be pulled into anything package wise, only used as a means to get targets to work on for the changed since option.

Aha! maybe an

experimental_shell_command

could work as go between, as a filter..

I still have no idea how we'd solve it, but at least worth documenting as an issue

That would be tricky to pull off because no “target generators” can synthesize a

_generator_sources_helper

target for the lockfile. There is no natural place to generate that. Whereas

python_requirements

can generate it for its

source

field

What if the

python_requirements

generator also generates a

_generator_sources_helper

for each

resolve

as a resolve requires a lockfile, that should be fine! (and skip that if resolves are not enabled, naturally) It’s just a matter of looking up the lockfile path for the each resolve.

(as was concluded in another thread, it wasn’t as easy to “abuse” the

_generator_sources_helper

explicitly in the BUILD file, as I can’t add the dependency in a clean way)

> I still have no idea how we’d solve it, but at least worth documenting as an issue

I can create a ticket later tonight (It’s a hassle to switch between GH accounts, as I have another one for iManage work)

https://github.com/pantsbuild/pants/pull/16934 @hundreds-father-404 I’d love some 👀 on this (when convenient), and would like picking to 2.14.x if at all possible 😉