Testing out Pants 2.14 and hit a surprising change...
# developments
sparse-lifeguard-95737
09/16/2022, 7:32 PMTesting out Pants 2.14 and hit a surprising change of behavior. I honestly don’t know how the previous behavior worked at all, but wanted to flag it in case it’s a regression.
We have a dir with:
Copy code
common.sh
test_common.sh
BUILD.pantstest_common.shcommon.shBUILD.pants Copy code
shell_sources()
shunit2_tests(name="tests", shell="bash")test_common.shcommon.shBUILD.pantssparse-lifeguard-95737
09/16/2022, 7:32 PMlooking at it, I have no clue how it worked without the explicit dependency before 2.14.x
sparse-lifeguard-95737
09/21/2022, 2:27 PM@hundreds-father-404 is there any chance that https://github.com/pantsbuild/pants/pull/16546 is the cause of the behavior change?
h
hundreds-father-404
09/21/2022, 4:57 PMOh hey sorry this didn't get a reply!
hundreds-father-404
09/21/2022, 4:59 PMHm, no, I'd be surprised if #16546 was relevant. That should only specify CLI args behavior
Could you plese confirm that
./pants dependencies --transitive test_common.sh👍 1
s
sparse-lifeguard-95737
09/21/2022, 5:19 PMbefore:
Copy code
$ ./pants dependencies --transitive build/pants/ci/test_common.sh
build/pants/ci/common.sh Copy code
$ ./pants dependencies --transitive build/pants/ci/test_common.shsparse-lifeguard-95737
09/21/2022, 5:20 PMI am more surprised it was working in 2.13.x w/o an explicit dependency - is there shell<->shell dependency inference?
h
hundreds-father-404
09/21/2022, 5:25 PMthere is! we run Shellcheck to parse your
sourcehundreds-father-404
09/21/2022, 5:25 PMthe sole thing that has changed here is Pants version? Not the bash code itself?
s
sparse-lifeguard-95737
09/21/2022, 5:26 PMYup!
sparse-lifeguard-95737
09/21/2022, 5:26 PMI can file an issue too now that I know it's a regression
sparse-lifeguard-95737
09/21/2022, 5:26 PMI had no clue there was inference here 🤯
h
hundreds-father-404
09/21/2022, 5:27 PMthat would help, especially if you can please include the file content. Fine if you have to scrub stuff, only lines with
source "foo". "foo"hundreds-father-404
09/21/2022, 5:27 PMyeah, the Shell backend is prob my favorite 😎
s
sparse-lifeguard-95737
09/21/2022, 7:44 PM